Skip to content

x/build/cmd/coordinator: health check for tip.golang.org reports a false positive of "404 not found" #47848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mknyszek opened this issue Aug 20, 2021 · 4 comments
Closed

x/build/cmd/coordinator: health check for tip.golang.org reports a false positive of "404 not found" #47848

mknyszek opened this issue Aug 20, 2021 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Aug 20, 2021 •
edited
Loading

https://farmer.golang.org/ is reporting https://tip.golang.org as down, but it's clearly up.

CC @rsc @dmitshur
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 20, 2021
@mknyszek mknyszek added this to the Unreleased milestone Aug 20, 2021
@mknyszek
Copy link
Contributor Author

Just kidding, this is likely due to a recent redeploy, and there's a lag. Closing.

@mknyszek
Copy link
Contributor Author

Just kidding again. Turns out this is weird. @dmitshur said he'd look into it.

@mknyszek mknyszek reopened this Aug 20, 2021
@dmitshur dmitshur self-assigned this Aug 20, 2021
@dmitshur dmitshur changed the title tip.golang.org: 404 not found x/build/cmd/coordinator: health check for tip.golang.org reports a false positive of "404 not found" Aug 20, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 20, 2021
@dmitshur
Copy link
Contributor

dmitshur commented Aug 20, 2021 •
edited
Loading

tip.golang.org is served by x/website/cmd/golangorg as of CL 335049, and we need to update this health check. It still points to a /_tipstatus URL, which isn't served by the new tip server, hence the 404 report.

We added that health check in CL 185981 for #15266, since back then it was served by an x/build service. I expect websites (tip.golang.org, go.dev, etc.) will have their own monitoring, and now that it's not tied to x/build infrastructure, there's no need for just a tip.golang.org health check to show up on https://farmer.golang.org/#health.

CC @rsc, @golang/release.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/343954 mentions this issue: cmd/coordinator: remove tip.golang.org health check

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 20, 2021
@heschi heschi moved this to Done in Go Release Sep 27, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot