Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: redirect wrongly to golang.google.cn #47846

Closed
xxchan opened this issue Aug 20, 2021 · 3 comments
Closed

x/website: redirect wrongly to golang.google.cn #47846

xxchan opened this issue Aug 20, 2021 · 3 comments

Comments

@xxchan
Copy link

xxchan commented Aug 20, 2021

I was reading go blog:

https://blog.golang.org/context

Yesterday, it redirects https://golang.google.cn/context and shows:
image

Similarly, report a website issue (https://golang.google.cn/issues/new?title=x/website:) redirects to https://golang.google.cn/issues/new?title=x/website: and show similar error.

And yesterday I found go.dev and blog https://go.dev/blog/context, it didn't redirect.
But today it also redirects to https://golang.google.cn/blog/context

@gopherbot gopherbot added this to the Unreleased milestone Aug 20, 2021
@mknyszek
Copy link
Contributor

Duplicate of #47808.

@gopherbot
Copy link

Change https://golang.org/cl/344009 mentions this issue: blog: fix internal blog page links

@gopherbot
Copy link

Change https://golang.org/cl/344010 mentions this issue: cmd/golangorg: disable China detection on go.dev

gopherbot pushed a commit to golang/website that referenced this issue Aug 20, 2021
Go.dev has never had golang.org's China detection
(which is there for historical reasons),
so we don't need to start now.

This fixes a problem with go.dev/blog redirecting to
golang.google.cn for users who are not actually in China.

Fixes golang/go#47846.

Change-Id: Ie1545c46aa881fd0ff3bccecf03002659a397c73
Reviewed-on: https://go-review.googlesource.com/c/website/+/344010
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
gopherbot pushed a commit to golang/website that referenced this issue Aug 23, 2021
When the blog moved from blog.golang.org/ to go.dev/blog/,
internal links like /blogpage needed to change to /blog/blogpage
and did not. This CL updates those links.

Fixes golang/go#47846.

Change-Id: I12a487062e19c7c5b619bd99f4488b3975e0d6d2
Reviewed-on: https://go-review.googlesource.com/c/website/+/344009
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@golang golang locked and limited conversation to collaborators Aug 20, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
Go.dev has never had golang.org's China detection
(which is there for historical reasons),
so we don't need to start now.

This fixes a problem with go.dev/blog redirecting to
golang.google.cn for users who are not actually in China.

Fixes golang/go#47846.

Change-Id: Ie1545c46aa881fd0ff3bccecf03002659a397c73
Reviewed-on: https://go-review.googlesource.com/c/website/+/344010
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
Website-Publish: Russ Cox <rsc@golang.org>
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
When the blog moved from blog.golang.org/ to go.dev/blog/,
internal links like /blogpage needed to change to /blog/blogpage
and did not. This CL updates those links.

Fixes golang/go#47846.

Change-Id: I12a487062e19c7c5b619bd99f4488b3975e0d6d2
Reviewed-on: https://go-review.googlesource.com/c/website/+/344009
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants