Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: grouped search fails to group some modules #47839

Closed
jba opened this issue Aug 20, 2021 · 2 comments
Closed

x/pkgsite: grouped search fails to group some modules #47839

jba opened this issue Aug 20, 2021 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Milestone
pkgsite/search

Comments

@jba
Copy link
Contributor

jba commented Aug 20, 2021

On https://beta.pkg.go.dev/search?q=xxhash, github.com/cespare/xxhash/v2 and github.com/cespare/xxhash aren't grouped together as "Other major versions."

For mvdan.cc/sh, is listed under v3, but also duplicated below it.
@jba jba added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Aug 20, 2021
@jba jba added this to the pkgsite/search milestone Aug 20, 2021
@jba jba self-assigned this Aug 20, 2021
@julieqiu
Copy link
Member

julieqiu commented Aug 20, 2021 •
edited

Here's an example for a gopkg.in package:

https://beta.pkg.go.dev/search?m=package&q=yaml

Screen Shot 2021-08-20 at 9 37 46 AM

In this case gopkg.in/yaml.v3 should be grouped under gopkg.in/yaml.v2, since gopkg.in/yaml.v3 does not have a tagged version.

Screen Shot 2021-08-20 at 9 38 23 AM

gopkg.in/yaml.v1 is farther down the page.

This was referenced Aug 20, 2021
Closed
Closed
@gopherbot
Copy link

Change https://golang.org/cl/345611 mentions this issue: internal/postgres: keep only one module major version in search grouping

@hyangah hyangah added the pkgsite/search Issues related to pkg.go.dev search functionality label May 20, 2022
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Milestone
pkgsite/search
Development

No branches or pull requests
4 participants
@hyangah @julieqiu @gopherbot @jba