Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/releasebot: pushing issues and closing milestone didn't work for major release #47787

Closed
dmitshur opened this issue Aug 18, 2021 · 1 comment
Closed

x/build/cmd/releasebot: pushing issues and closing milestone didn't work for major release #47787

dmitshur opened this issue Aug 18, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release Team
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Aug 18, 2021 •
edited

There seems to be a problem in pushIssues for major releases. It's documented to move issues for major releases:

// pushIssues moves open issues to the milestone of the next release of the same kind.
// For major releases, it's the milestone of the next major release (e.g., 1.14 → 1.15).
// For minor releases, it's the milestone of the next minor release (e.g., 1.14.1 → 1.14.2).
// For other release types, it does nothing.
func (w *Work) pushIssues()

Yet it didn't move issues for the Go 1.17 release, issue #47719.

The milestone wasn't closed either, despite the log message:

2021/08/16 17:01:07 closing milestone go1.17

From a quick look, a hypothesis is that gopherbot may have incorrectly thought milestone was "go1.17" (lower-case 'g'), but it's actually "Go1.17", and maybe GitHub is case sensitive (or has become). Edit: This hypothesis wasn't right.

CC @golang/release, @mknyszek.
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 18, 2021
@dmitshur dmitshur added this to the Unreleased milestone Aug 18, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 18, 2021
@dmitshur
Copy link
Contributor Author

It worked fine for Go 1.18, moving 8 non-release-blocking issues from Go1.18 milestone to Go1.19 (as seen here).

There were some changes that might've helped, so maybe it was that, or maybe something else. Either way, closing because there's nothing more to do here for now.

@dmitshur dmitshur added this to Done in Go Release Team Mar 22, 2022
@golang golang locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot