Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: wrong dynamic linker path when cross-compiling to OpenBSD [1.17 backport] #47782

Closed
gopherbot opened this issue Aug 18, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link

@cherrymui requested issue #47760 to be considered for backport to the next 1.17 minor release.

@gopherbot please backport this to Go 1.17. This is a regression. Thanks.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 18, 2021
@gopherbot gopherbot added this to the Go1.17.1 milestone Aug 18, 2021
@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Aug 18, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 18, 2021
@mknyszek
Copy link
Contributor

This is not the user experience we want people to have when cross-compiling and definitely a regression.

@gopherbot
Copy link
Author

Change https://golang.org/cl/343309 mentions this issue: [release-branch.go1.17] cmd/link: do not use GO_LDSO when cross compile

@gopherbot
Copy link
Author

Closed by merging 47a57bc to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Sep 1, 2021
GO_LDSO is a setting that is set when the toolchain is build. It
only makes sense to use it on the host platform. Do not use it
when targetting a different platform.

In the past it was not a problem as GO_LDSO was almost always
unset. Now, with CL 301989 it is almost always set (maybe we want
to revisit it).

Updates #47760.
Fixes #47782.

Change-Id: I2704b9968781f46e2d2f8624090db19689b1a32f
Reviewed-on: https://go-review.googlesource.com/c/go/+/343010
Trust: Cherry Mui <cherryyz@google.com>
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit ddfcc02)
Reviewed-on: https://go-review.googlesource.com/c/go/+/343309
@golang golang locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants