Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed: 1.17 rejects types with underlying type []byte [1.17 backport] #47754

Closed
gopherbot opened this issue Aug 17, 2021 · 4 comments
Closed

embed: 1.17 rejects types with underlying type []byte [1.17 backport] #47754

gopherbot opened this issue Aug 17, 2021 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.1

Comments

@gopherbot
Copy link

@randall77 requested issue #47735 to be considered for backport to the next 1.17 minor release.

@gopherbot please open a backport issue for 1.17.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 17, 2021
@gopherbot gopherbot mentioned this issue Aug 17, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.1 milestone Aug 17, 2021
@randall77
Copy link
Contributor

Programs that used to compile with 1.16 have stopped compiling for 1.17. Workarounds are possible, but can be annoying if in a dependency.

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Aug 18, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Aug 18, 2021
@mknyszek
Copy link
Contributor

What Keith said.

@gopherbot
Copy link
Author

Change https://golang.org/cl/345092 mentions this issue: [release-branch.go1.17] cmd/compile: allow embed into any byte slice type

@gopherbot
Copy link
Author

Closed by merging 2d97a87 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Sep 1, 2021
@randall77 @cherrymui
[release-branch.go1.17] cmd/compile: allow embed into any byte slice …
2d97a87 
…type

Fixes #47754

Change-Id: Ia21ea9a67f36a3edfef1b299ae4f3b00c306cd68
Reviewed-on: https://go-review.googlesource.com/c/go/+/345092
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@tnozicka tnozicka mentioned this issue Oct 11, 2021
Merged
@golang golang locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.1
Development

No branches or pull requests
3 participants
@mknyszek @randall77 @gopherbot