Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: /ref/mod page runs into template execution error as of CL 339403 #47751

Closed
AlekSi opened this issue Aug 17, 2021 · 6 comments
Closed

x/website: /ref/mod page runs into template execution error as of CL 339403 #47751

AlekSi opened this issue Aug 17, 2021 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@AlekSi
Copy link
Contributor

AlekSi commented Aug 17, 2021

What did you do?

Opened https://golang.org/ref/mod in Safari 14.1.2 on macOS 11.5.1.

What did you expect to see?

Working website.

What did you see instead?

image
@AlekSi
Copy link
Contributor Author

AlekSi commented Aug 17, 2021

I guess it is the same as #47750.

@AlekSi AlekSi closed this as completed Aug 17, 2021
@AlekSi AlekSi reopened this Aug 17, 2021
@AlekSi
Copy link
Contributor Author

AlekSi commented Aug 17, 2021

Or not, as this issue is about golang.org, not golang.google.cn

@seankhliao seankhliao changed the title https://golang.org/ref/mod is broken right now x/website: /ref/mod template execution error Aug 17, 2021
@gopherbot gopherbot added this to the Unreleased milestone Aug 17, 2021
@seankhliao
Copy link
Member

cc @dmitshur

@dmitshur
Copy link
Contributor

dmitshur commented Aug 17, 2021 •
edited

Thanks for reporting.

The last good version was golang/website@f8f1822, rolled back golang.org to that as a temporary mitigation.

The problem is introduced with the following commit, golang/website@ef7fed4.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 17, 2021
@dmitshur dmitshur changed the title x/website: /ref/mod template execution error x/website: /ref/mod page runs into template execution error as of CL 339403 Aug 17, 2021
@dmitshur dmitshur mentioned this issue Aug 17, 2021
Closed
@forging2012
Copy link

Nice job!
It has now recovered.
Thanks all!

@gopherbot
Copy link

Change https://golang.org/cl/342899 mentions this issue: cmd/golangorg: fix ref/mod to be template-safe and add exhaustive template syntax test

@rsc rsc removed their assignment Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
cmd/golangorg: fix ref/mod to be template-safe and add exhaustive tem…
347bfd0 
…plate syntax test

Fixes golang/go#47751.

Change-Id: I28a979eee3c75749449291d0b60bc64a6d761ae0
Reviewed-on: https://go-review.googlesource.com/c/website/+/342899
Trust: Russ Cox <rsc@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@AlekSi @rsc @dmitshur @forging2012 @gopherbot @seankhliao