…ntly

SetRequireSeparateIndirect now makes a stronger attempt to keep
automatically added requirements in two blocks: one containing only
direct requirements and one containing only indirect
requirements. SetRequireSeparateIndirect will find or add these two
blocks (commented blocks are left alone). New requirements are added
to one of these two blocks. Existing requirements may be moved between
these two blocks if their markings change.

SetRequireSeparateIndirect attempts to preserve existing structure in
the file by not adding requirements to or moving requirements from
blocks with block-level comments and blocks other than the last
uncommented direct-only and indirect-only block.

As an exception to aid with migration, if the file contains a single
uncommented block of requirements (as would the be the case if the
user started with a 1.16 go.mod file, changed the go directive to
1.17, then ran 'go mod tidy'), SetRequireSeparateIndirect will split
the block into direct-only and indirect-only blocks.

This is a change in behavior, but it has no semantic effect, and it
should result in cleaner, more stable go.mod files.

For golang/go#47563
For golang/go#47733

Change-Id: Ifa20bb084c6bdaf1e00140600380857de8afa320
Reviewed-on: https://go-review.googlesource.com/c/mod/+/343431
Trust: Jay Conrod <jayconrod@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>

When reading go.mod, SetRequireSeparateIndirect will insert new
requirements into the last uncommented direct-only or indirect-only
block OR line. If the last such statement is a line,
SetRequireSeparateIndirect converts it to a block before inserting new
requirements. Cleanup will convert it back to a line later if no
requirements are inserted.

For golang/go#47733

Change-Id: Id8ee3b0ce2d005488ddb3d9a5349115bd93938e7
Reviewed-on: https://go-review.googlesource.com/c/mod/+/348576
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>

The command ´go mod tidy´ [1] can be used to update the ´go.mod` file so
that it contains exactly the actually used dependencies. Doing so
results in all indirect dependencies being added to the ´go.mod´ file
with a trailing comment, ´// indirect´, to indicate that it is an
indirect dependency, see also [2]. As ´go mod graph´ does not
interprete these comments, its output graph contains edges between the
main module and each indirect dependency. Skip these edges to avoid
flattening the dependency tree.

[1] https://go.dev/ref/mod#go-mod-tidy
[2] golang/go#47733 (comment)

Signed-off-by: Frank Viernau <frank_viernau@epam.com>

The command `go mod tidy` [1] can be used to update the `go.mod` file so
that it contains exactly the actually used dependencies. Doing so
results in all indirect dependencies being added to the `go.mod` file
with a trailing comment, `// indirect`, to indicate that it is an
indirect dependency, see also [2]. As `go mod graph` does not
interprete these comments, its output graph contains edges between the
main module and each indirect dependency. Skip these edges to avoid
flattening the dependency tree.

[1] https://go.dev/ref/mod#go-mod-tidy
[2] golang/go#47733 (comment)

Signed-off-by: Frank Viernau <frank_viernau@epam.com>

The command `go mod tidy` [1] can be used to update the `go.mod` file so
that it contains exactly the actually used dependencies. Doing so
results in all indirect dependencies being added to the `go.mod` file
with a trailing comment, `// indirect`, to indicate that it is an
indirect dependency, see also [2]. As `go mod graph` does not
interprete these comments, its output graph contains edges between the
main module and each indirect dependency. Skip these edges to avoid
flattening the dependency tree.

[1] https://go.dev/ref/mod#go-mod-tidy
[2] golang/go#47733 (comment)

Signed-off-by: Frank Viernau <frank_viernau@epam.com>

The command `go mod tidy` [1] can be used to update the `go.mod` file so
that it contains exactly the actually used dependencies. Doing so
results in all indirect dependencies being added to the `go.mod` file
with a trailing comment, `// indirect`, to indicate that it is an
indirect dependency, see also [2]. As `go mod graph` does not
interprete these comments, its output graph contains edges between the
main module and each indirect dependency. Skip these edges to avoid
flattening the dependency tree.

[1] https://go.dev/ref/mod#go-mod-tidy
[2] golang/go#47733 (comment)

Signed-off-by: Frank Viernau <frank_viernau@epam.com>

The command `go mod tidy` [1] can be used to update the `go.mod` file so
that it contains exactly the actually used dependencies. Doing so
results in all indirect dependencies being added to the `go.mod` file
with a trailing comment, `// indirect`, to indicate that it is an
indirect dependency, see also [2]. As `go mod graph` does not
interprete these comments, its output graph contains edges between the
main module and each indirect dependency. Skip these edges to avoid
flattening the dependency tree.

[1] https://go.dev/ref/mod#go-mod-tidy
[2] golang/go#47733 (comment)

Signed-off-by: Frank Viernau <frank_viernau@epam.com>

The command `go mod tidy` [1] can be used to update the `go.mod` file so
that it contains exactly the actually used dependencies. Doing so
results in all indirect dependencies being added to the `go.mod` file
with a trailing comment, `// indirect`, to indicate that it is an
indirect dependency, see also [2]. As `go mod graph` does not
interprete these comments, its output graph contains edges between the
main module and each indirect dependency. Skip these edges to avoid
flattening the dependency tree.

[1] https://go.dev/ref/mod#go-mod-tidy
[2] golang/go#47733 (comment)

Signed-off-by: Frank Viernau <frank_viernau@epam.com>