Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync/atomic: CompareAndSwapPointer should be CompareAndSwap [1.17 backport] #47703

Closed
gopherbot opened this issue Aug 14, 2021 · 5 comments
Closed

sync/atomic: CompareAndSwapPointer should be CompareAndSwap [1.17 backport] #47703

gopherbot opened this issue Aug 14, 2021 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Milestone
Go1.17

Comments

@gopherbot
Copy link

@rhysh requested issue #47699 to be considered for backport to the next 1.17 minor release.

CC @golang/release , this is a new API for Go 1.17, and the release branch doesn't have the fix yet (see https://github.com/golang/go/blob/release-branch.go1.17/src/sync/atomic/value.go#L129 ). For your consideration, so it doesn't get lost in the shuffle on Monday.

@gopherbot please backport to 1.17
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 14, 2021
@gopherbot gopherbot mentioned this issue Aug 14, 2021
Closed
@rhysh
Copy link
Contributor

rhysh commented Aug 14, 2021

I don't have the impersonate / forge author permission, so I can't personally do the cherry-pick of https://go-review.googlesource.com/c/go/+/342210: email address [redacted] is not registered in your account, and you lack 'forge author' permission.

@ianlancetaylor
Copy link
Contributor

I have permission but I'm getting "internal server error". I guess I'll try again later.

@dmitshur dmitshur added this to the Go1.17 milestone Aug 15, 2021
@dmitshur
Copy link
Contributor

Approved as a documentation fix for a new-to-Go-1.17 API. Only 1.17 needs this backport.

@gopherbot
Copy link
Author

Change https://golang.org/cl/342329 mentions this issue: [release-branch.go1.17] sync/atomic: fix documentation for CompareAndSwap

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 15, 2021
@gopherbot
Copy link
Author

Closed by merging fdd6dfd to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Aug 15, 2021
@shoenseiwaso @dmitshur
[release-branch.go1.17] sync/atomic: fix documentation for CompareAnd…
fdd6dfd 
…Swap

The documentation for CompareAndSwap atomic/value incorrectly labelled
the function as CompareAndSwapPointer. This PR fixes that.

Updates #47699.
Fixes #47703.

Change-Id: I6db08fdfe166570b775248fd24550f5d28e3434e
GitHub-Last-Rev: 41f7870
GitHub-Pull-Request: #47700
Reviewed-on: https://go-review.googlesource.com/c/go/+/342210
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Trust: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 0a0a160)
Reviewed-on: https://go-review.googlesource.com/c/go/+/342329
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.17
Development

No branches or pull requests
4 participants
@rhysh @dmitshur @ianlancetaylor @gopherbot