Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/devapp: https://dev.golang.org/reviews page was unavailable on Aug 13, 2021 due to unexpected Gerrit behavior #47695

Closed
rhysh opened this issue Aug 13, 2021 · 5 comments
Closed

x/build/devapp: https://dev.golang.org/reviews page was unavailable on Aug 13, 2021 due to unexpected Gerrit behavior #47695

rhysh opened this issue Aug 13, 2021 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@rhysh
Copy link
Contributor

rhysh commented Aug 13, 2021

What version of Go are you using (go version)?

N/A

Does this issue reproduce with the latest release?

This is a problem with a live website.

What operating system and processor architecture are you using (go env)?

N/A

What did you do?

I opened https://dev.golang.org/ in my browser and clicked the "Open reviews" link.

What did you expect to see?

A list of Gerrit links

What did you see instead?

https://dev.golang.org/reviews in Chrome shows an error page referencing "ERR_HTTP2_PROTOCOL_ERROR". Curl also reports a problem:

$ curl https://dev.golang.org/reviews
curl: (92) HTTP/2 stream 1 was not closed cleanly: INTERNAL_ERROR (err 2)
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 13, 2021
@gopherbot gopherbot added this to the Unreleased milestone Aug 13, 2021
@rhysh
Copy link
Contributor Author

rhysh commented Aug 13, 2021

With HTTP/1.1, it's an empty response (no headers). Maybe a panic before the first write to the body (or WriteHeader). Not specific to http/2.

$ curl --http1.1 https://dev.golang.org/reviews
curl: (52) Empty reply from server

@rhysh rhysh changed the title x/build/devapp: http/2 protocol error on https://dev.golang.org/reviews x/build/devapp: no response for https://dev.golang.org/reviews (protocol error) Aug 13, 2021
@dmitshur
Copy link
Contributor

Thanks for reporting.

I'm not able to reproduce the issue right now (which is 1-2 hours after the report). What about you @rhysh, does it still reproduce for you?

I do see in logs there have been panics. There was an issue with Gerrit (go-review.googlesource.com) that coincides with the time of this report, and it looks like it uncovered some possible panics in golang.org/x/build/maintner.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 13, 2021
@rhysh
Copy link
Contributor Author

rhysh commented Aug 13, 2021

Yes, the page loads for me now too. Thanks for investigating!

@dmitshur dmitshur changed the title x/build/devapp: no response for https://dev.golang.org/reviews (protocol error) x/build/devapp: https://dev.golang.org/reviews page was unavailable on Aug 13, 2021 due to unexpected Gerrit behavior Aug 14, 2021
@dmitshur dmitshur mentioned this issue Jan 6, 2022
Closed
@dmitshur
Copy link
Contributor

dmitshur commented Jan 6, 2022

I've looked into the panic in golang.org/x/build/maintner, and it seems the panic cannot happen under normal situations, only if Gerrit is misbehaving somehow. Since it only happened that one time so far, I can't tell if it was a one-off problem that was resolved, or something we need to update the code to anticipate happening again.

I filed #50474 for tracking the problem in maintner, and will close this issue since it's resolved.

@dmitshur dmitshur closed this as completed Jan 6, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/408194 mentions this issue: devapp: propagate updateReviewsData error from ForeachProjectUnsorted

gopherbot pushed a commit to golang/build that referenced this issue May 24, 2022
@dmitshur @gopherbot
devapp: propagate updateReviewsData error from ForeachProjectUnsorted
fb495b9 
CL 407394 added a detailed error in case of a rare, unexpected problem.
Propagate it in one more place so we benefit from the new information
if this happens again.

Updates golang/go#47695.
Updates golang/go#50474.

Change-Id: Iddb9a8d8de320d535fd15842c60bf0274391f8f2
Reviewed-on: https://go-review.googlesource.com/c/build/+/408194
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@rhysh @dmitshur @gopherbot