Change https://golang.org/cl/341850 mentions this issue: internal/lsp/source/completion: exclude 'any' from lexical results

Repurposing this issue: now any is allowed everywhere!

So we need to revert the above CL, as as well as other places where we exclude any.

I just looked into this, and we seem to be suggesting completion to 'any' in places where we shouldn't. Needs more investigation.

Ok, it seems that completion just includes more results than I had assumed.

For example, from internal/lsp/testdata/rank/binexpr_rank.go.in:

func _() {
  _ = 5 +  ; //@complete(" ;", apple, pear)
}

We suggest any as a completion here, albeit with a low score, even though its type does not match. Specifically, we get here, and keep going even though c.matchingCandidate(cand) returns false.

Given that we downrank, this is fine, but it does seem a bit noisy. @muirdm do you have an opinion on whether we should be suggesting any at all in this context? I would trust your intuition as to whether (1) we shouldn't offer completions that don't match the inferred type, or (2) we should offer (but downrank) all lexical completions. It may eb

I don't think this it is a high priority to resolve this for v0.8.0, so moving it to the v0.8.1 milestone while we discuss.

I think you want to add "any" to tools/internal/lsp/tests/util.go:isBuiltin. That is used to filter buiiltin candidates in completion tests.

We don't filter type names in general because it's hard to predict what the user wants to do. For example, they may want to complete to an incompatible type "someType" so they can write "someType(foo).someMethod()". Or maybe they don't realize the type is incompatible and would be confused by it not showing up. Or maybe they are composing an expression inside-out where they first insert "someType{}" and then wrap it in "somethingElse(someType{})".

"any" in particular doesn't seem useful, but unless there is a compelling reason to filter it I wouldn't bother.

Haven't gotten to this, and it's a low priority because including 'any' in results doesn't add a huge amount of value. Bumping to the backlog.

Change https://go.dev/cl/463139 mentions this issue: gopls: allow 'any' and 'comparable' in completion results