Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/_content/ref: lang version determining rule should be documented in Go Module Reference #47662

Closed
go101 opened this issue Aug 12, 2021 · 4 comments
Closed

x/website/_content/ref: lang version determining rule should be documented in Go Module Reference #47662

go101 opened this issue Aug 12, 2021 · 4 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1
Milestone
Go1.18

Comments

@go101
Copy link

go101 commented Aug 12, 2021

The behavior implemented in #44976 should be documented at this section: https://golang.org/ref/mod#go-mod-file-go

ref: https://groups.google.com/g/golang-nuts/c/lhedc8YaWlM
@go101 go101 changed the title go/compile: lang version determining rule should be documented document: lang version determining rule should be documented Aug 12, 2021
@go101
Copy link
Author

go101 commented Aug 12, 2021

And as Ian mentioned, maybe the -lang version set in -gcflags should shadow the default 1.16 value.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 12, 2021
@dmitshur dmitshur changed the title document: lang version determining rule should be documented x/website/_content/ref: lang version determining rule should be documented in Go Module Reference Aug 12, 2021
@gopherbot gopherbot added this to the Unreleased milestone Aug 12, 2021
@dmitshur dmitshur added this to the Unreleased milestone Aug 12, 2021
@dmitshur
Copy link
Contributor

CC @bcmills.

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Aug 12, 2021
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 12, 2021
@bcmills
Copy link
Contributor

bcmills commented Aug 12, 2021

And as Ian mentioned, maybe the -lang version set in -gcflags should shadow the default 1.16 value.

That seems fine, but please file a separate issue for it.

@bcmills bcmills self-assigned this Aug 12, 2021
@bcmills bcmills modified the milestones: Unreleased, Go1.18 Aug 27, 2021
@bcmills bcmills added the okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 label Nov 10, 2021
@gopherbot
Copy link

Change https://golang.org/cl/381895 mentions this issue: _content/ref/mod: "go 1.16" is the default in go.mod

@rsc rsc unassigned bcmills Jun 23, 2022
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
_content/ref/mod: "go 1.16" is the default in go.mod
8dd0db2 
Fixes golang/go#47662

Change-Id: Ie4d327a48d426ce1cd4a5bd411186143fecf00e1
Reviewed-on: https://go-review.googlesource.com/c/website/+/381895
Reviewed-by: Bryan Mills <bcmills@google.com>
Trust: DO NOT USE <iant@google.com>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @go101