Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/internal/gccgoimporter: TestInstallationImporter broken with tip gccgo [1.16 backport] #47610

Closed
gopherbot opened this issue Aug 9, 2021 · 3 comments
Closed

go/internal/gccgoimporter: TestInstallationImporter broken with tip gccgo [1.16 backport] #47610

gopherbot opened this issue Aug 9, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16.8

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #44425 to be considered for backport to the next 1.16 minor release.

@gopherbot Please backport to 1.16

This is fixed on tip, but causes a test failure on 1.16 when gccgo is installed. The fix is trivial (https://golang.org/cl/294290) so let's backport it.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 9, 2021
@gopherbot gopherbot mentioned this issue Aug 9, 2021
Closed
@gopherbot gopherbot modified the milestones: Gccgo, Go1.16.8 Aug 9, 2021
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 9, 2021
@ianlancetaylor ianlancetaylor mentioned this issue Aug 9, 2021
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/340952 mentions this issue: [release-branch.go1.16] go/internal/gccgoimporter: fix up gccgo installation test

@dmitshur
Copy link
Contributor

Approving as a test-only fix, needed only for Go 1.16.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 11, 2021
@gopherbot
Copy link
Author

Closed by merging d66b211 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Aug 11, 2021
@thanm @ianlancetaylor
[release-branch.go1.16] go/internal/gccgoimporter: fix up gccgo insta…
d66b211 
…llation test

Change the TestInstallationImporter testpoint to query type
information for sort.Search instead of sort.Ints. The latter function
changed recently (1.16 timeframe), parameter "a" is now "x". A better
candidate for this sort of query is sort.Search, which has been stable
for a while.

Fixes #47610.

Change-Id: I314476eac0b0802f86f5cbce32195cab2926db83
Reviewed-on: https://go-review.googlesource.com/c/go/+/294290
Trust: Than McIntosh <thanm@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 0f66fb7)
Reviewed-on: https://go-review.googlesource.com/c/go/+/340952
@golang golang locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16.8
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot