You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dmitshur
changed the title
go/internal/gccgoimporter_test.go not updated after sort.Ints’ declaration was updated - v1.16.7
go/internal/gccgoimporter: gccgoimporter_test.go not updated after sort.Ints’ declaration was updated in Go 1.16.7
Aug 9, 2021
Thanks. This is a dup of #44425, which is fixed on tip and in the upcoming 1.17 release. I opened #47610 to backport that fix to the 1.16 release. Closing this issue. Thanks for reporting it.
With
I do “git checkout go1.16.7 == commit fa6aa87”, then ./src/make.bask ; ./src/make.all . It fails with
ok go/format 0.018s
ok go/importer 0.109s
--- FAIL: TestInstallationImporter (1.73s)
importer_test.go:40: Ints: got "func Ints(x []int)"; want "func Ints(a []int)"
FAIL
FAIL go/internal/gccgoimporter 4.042s
ok go/internal/gcimporter 0.674s
ok go/internal/srcimporter 12.344s
The fails seems to origin in
After this commit the test in
src/go/internal/gccgoimporter/gccgoinstallation_test.go:187: {pkgpath: "sort", name: "Ints", want: "func Ints(a []int)"},
was not adjusted.
Proposed patch:
The text was updated successfully, but these errors were encountered: