Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: remove retracted versions from search results #47590

Closed
jba opened this issue Aug 7, 2021 · 4 comments
Closed

x/pkgsite: remove retracted versions from search results #47590

jba opened this issue Aug 7, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone
pkgsite/package-r...

Comments

@jba
Copy link
Contributor

jba commented Aug 7, 2021

We don't insert a retracted version into search results when we process it, but we also don't remove it if the retraction happens later.
@jba jba added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Aug 7, 2021
@jba jba added this to the pkgsite/unplanned milestone Aug 7, 2021
@jba jba self-assigned this Aug 7, 2021
This was referenced Aug 7, 2021
Closed
Closed
@akshayjshah
Copy link
Contributor

I've lost track of the open-source status of pkg.go.dev - is this something that I can help with, or is the source Google-internal?

@mvdan
Copy link
Member

mvdan commented Aug 8, 2021

@akshayjshah https://github.com/golang/pkgsite

@gopherbot
Copy link

Change https://golang.org/cl/341591 mentions this issue: internal/postgres: remove a fully retracted module from search

gopherbot pushed a commit to golang/pkgsite that referenced this issue Aug 12, 2021
@jba
internal/postgres: remove a fully retracted module from search
80022c8 
If all the versions of a module have been retracted, remove it
from the search_documents table so it doesn't appear in search.

Also remove it from the imports_unique table so it doesn't contribute
to the imported-by counts of other modules.

For golang/go#47590

Change-Id: I76a6e33a1291abe4a19f1b3521c9dc8ebed4f110
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/341591
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@jba
Copy link
Contributor Author

jba commented Aug 13, 2021

Now live.

@jba jba closed this as completed Aug 13, 2021
@bcmills bcmills mentioned this issue Oct 26, 2021
Closed
@hyangah hyangah added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label May 20, 2022
@rsc rsc unassigned jba Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Milestone
pkgsite/package-removal
Development

No branches or pull requests
6 participants
@akshayjshah @mvdan @hyangah @julieqiu @gopherbot @jba