x/tools/gopls: features don't work with multiple command-line-arguments (adhoc) packages #47584
Comments
enkeyz
changed the title
enkeyz
changed the title
|
Hi! In general, you'll get an error with multiple main functions but autocomplete and other functionality should continue to work. I think what's happening here is that you are are neither in GOPATH nor a module, and gopls is falling back to single-file mode (#34160). That should still work, but perhaps there's a bug. I haven't yet been able to reproduce the behavior you're observing in any of GOPATH, module, or single file mode. Could you please share the version of gopls you are using? It's apparently not in your PATH, but from your gist it is at Could you also capture gopls logs from a session where you reproduce the poor behavior? Preferably a short-lived session. You can find instructions for how to do this here: More generally note that if there are two files with |
|
The problem was solved by adding GOPATH to the PATH. I'm using this PPA: https://launchpad.net/~longsleep/+archive/ubuntu/golang-backports for installing Go, but looks like it didn't add GOPATH after install. |
|
@enkeyz despite not having GOPATH in PATH, can you confirm that you did have gopls installed? |
|
Yes, I can confirm that gopls was installed. |
|
@findleyr I could reproduce the case (gopls v0.7.1) but it's somewhat non-deterministic at this moment. (sometimes it works, sometimes it stops working... Had to reload and retry multiple times to reproduce the problem myself)
No % tree . ├── ch1 │ ├── echo1.go │ └── main.go └── test.go gopls log[Trace - 13:44:18.712 PM] Sending request 'initialize - (0)'.
Params: {"processId":88122,"clientInfo":{"name":"Visual Studio Code","version":"1.58.2"},"locale":"en-us","rootPath":"/Users/hakim/projects/s","rootUri":"file:///Users/hakim/projects/s","capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{"documentChanges":true,"resourceOperations":["create","rename","delete"],"failureHandling":"textOnlyTransactional","normalizesLineEndings":true,"changeAnnotationSupport":{"groupsOnLabel":true}},"didChangeConfiguration":{"dynamicRegistration":true},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"tagSupport":{"valueSet":[1]}},"codeLens":{"refreshSupport":true},"executeCommand":{"dynamicRegistration":true},"configuration":true,"workspaceFolders":true,"semanticTokens":{"refreshSupport":true},"fileOperations":{"dynamicRegistration":true,"didCreate":true,"didRename":true,"didDelete":true,"willCreate":true,"willRename":true,"willDelete":true}},"textDocument":{"publishDiagnostics":{"relatedInformation":true,"versionSupport":false,"tagSupport":{"valueSet":[1,2]},"codeDescriptionSupport":true,"dataSupport":true},"synchronization":{"dynamicRegistration":true,"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"dynamicRegistration":true,"contextSupport":true,"completionItem":{"snippetSupport":true,"commitCharactersSupport":true,"documentationFormat":["markdown","plaintext"],"deprecatedSupport":true,"preselectSupport":true,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":true,"resolveSupport":{"properties":["documentation","detail","additionalTextEdits"]},"insertTextModeSupport":{"valueSet":[1,2]}},"completionItemKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25]}},"hover":{"dynamicRegistration":true,"contentFormat":["markdown","plaintext"]},"signatureHelp":{"dynamicRegistration":true,"signatureInformation":{"documentationFormat":["markdown","plaintext"],"parameterInformation":{"labelOffsetSupport":true},"activeParameterSupport":true},"contextSupport":true},"definition":{"dynamicRegistration":true,"linkSupport":true},"references":{"dynamicRegistration":true},"documentHighlight":{"dynamicRegistration":true},"documentSymbol":{"dynamicRegistration":true,"symbolKind":{"valueSet":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26]},"hierarchicalDocumentSymbolSupport":true,"tagSupport":{"valueSet":[1]},"labelSupport":true},"codeAction":{"dynamicRegistration":true,"isPreferredSupport":true,"disabledSupport":true,"dataSupport":true,"resolveSupport":{"properties":["edit"]},"codeActionLiteralSupport":{"codeActionKind":{"valueSet":["","quickfix","refactor","refactor.extract","refactor.inline","refactor.rewrite","source","source.organizeImports"]}},"honorsChangeAnnotations":false},"codeLens":{"dynamicRegistration":true},"formatting":{"dynamicRegistration":true},"rangeFormatting":{"dynamicRegistration":true},"onTypeFormatting":{"dynamicRegistration":true},"rename":{"dynamicRegistration":true,"prepareSupport":true,"prepareSupportDefaultBehavior":1,"honorsChangeAnnotations":true},"documentLink":{"dynamicRegistration":true,"tooltipSupport":true},"typeDefinition":{"dynamicRegistration":true,"linkSupport":true},"implementation":{"dynamicRegistration":true,"linkSupport":true},"colorProvider":{"dynamicRegistration":true},"foldingRange":{"dynamicRegistration":true,"rangeLimit":5000,"lineFoldingOnly":true},"declaration":{"dynamicRegistration":true,"linkSupport":true},"selectionRange":{"dynamicRegistration":true},"callHierarchy":{"dynamicRegistration":true},"semanticTokens":{"dynamicRegistration":true,"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":["relative"],"requests":{"range":true,"full":{"delta":true}},"multilineTokenSupport":false,"overlappingTokenSupport":false},"linkedEditingRange":{"dynamicRegistration":true}},"window":{"showMessage":{"messageActionItem":{"additionalPropertiesSupport":true}},"showDocument":{"support":true},"workDoneProgress":true},"general":{"regularExpressions":{"engine":"ECMAScript","version":"ES2020"},"markdown":{"parser":"marked","version":"1.1.0"}}},"initializationOptions":{},"trace":"off","workspaceFolders":[{"uri":"file:///Users/hakim/projects/s","name":"s"}]}
@enkeyz Since you are using 1.16, I strongly recommend to create |
stamblerre
changed the title
gopherbot
added
Tools
|
Transferring to I was able to reproduce the issue, and I got error messages such as: |
|
Change https://golang.org/cl/341611 mentions this issue: |
For asking questions, see:
#vscodechannel in Gophers SlackBefore filing an issue, please review our troubleshooting guides
Please answer these questions before submitting your issue. Thanks!
What version of Go, VS Code & VS Code Go extension are you using?
go versionto get version of Go from the VS Code integrated terminal.gopls -v versionto get version of Gopls from the VS Code integrated terminal.code -vorcode-insiders -vto get version of VS Code or VS Code Insiders.Go: Locate Configured Go Toolscommand.- https://gist.github.com/enkeyz/5a4dfbc87c40a17ccb3f5f3f0f7548a7
Share the Go related settings you have added/edited
Run
Preferences: Open Settings (JSON)command to open your settings.json file.Share all the settings with the
go.or["go"]orgoplsprefixes.- https://gist.github.com/enkeyz/bf091db4170845a86259bdb61143b213
Describe the bug
When you have multiple go files in a directory - and not in a module - with package main, and each file has a main function, autocomplete stops working for all files except the one you opened last. Also the function description stops working - when hovering over the function name.
I'm still learning Go, and it's really hard to experiment when you can only have one file with main function.
The only workaround to put each file with main function in a different directory, and open each directory with vscode.
Steps to reproduce the behavior:
Screenshots or recordings
Last created file:
Switching back to previously created file:
The text was updated successfully, but these errors were encountered: