Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: unexpected error on renaming shadowed variable #47583

Closed
suzmue opened this issue Aug 6, 2021 · 1 comment
Closed

x/tools/gopls: unexpected error on renaming shadowed variable #47583

suzmue opened this issue Aug 6, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.2

Comments

@suzmue
Copy link
Contributor

suzmue commented Aug 6, 2021 

$ gopls version
golang.org/x/tools/gopls v0.7.1
    golang.org/x/tools/gopls@v0.7.1 h1:Mh3Z8Xcoq3Zy7ksSlwDV/nzQSbjFf06A+L+F8YHq55U=

What did you do?

Rename F to f

package shadow

func _() {
    f := F()
    _ = f
}

func F() int {
    return 0
}

What did you expect to see?

F to be renamed

What did you see instead?

Rename error

renaming this func "F" to "f" would cause this reference to become shadowed by this intervening var definition
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 6, 2021
@gopherbot gopherbot added this to the Unreleased milestone Aug 6, 2021
@gopherbot
Copy link

Change https://golang.org/cl/340551 mentions this issue: internal/lsp: make lexicalLookup check more granular

@golang golang locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.2
Development

No branches or pull requests
3 participants
@stamblerre @suzmue @gopherbot