Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: always pass -intgosize flag to swig #4756

Closed
gopherbot opened this issue Feb 4, 2013 · 8 comments
Closed

cmd/go: always pass -intgosize flag to swig #4756

gopherbot opened this issue Feb 4, 2013 · 8 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.1

Comments

@gopherbot
Copy link

by giacomo.tartari:

What steps will reproduce the problem?
cd $GOROOT/misc/swig/callback/

$ go build
# _/Users/giacomo/go/misc/swig/callback
SWIG -go: -intgosize option required but not specified

Which compiler are you using (5g, 6g, 8g, gccgo)?
6g


Which operating system are you using?
Mac OS Lion  10.7.5 x86_64


Which version are you using?  (run 'go version')
$ go version
go version devel +437d7aefea45 Mon Feb 04 00:40:11 2013 +0800 darwin/amd64

$ swig -version
SWIG Version 2.0.9
Compiled with g++ [i386-apple-darwin11.4.2]
Configured options: +pcre
@gopherbot
Copy link
Author

Comment 1 by giacomo.tartari:

Link do golang-nuts discusion
https://groups.google.com/d/msg/golang-nuts/U-1Ih--TIKc/ZsLJL_KVH-4J

@minux
Copy link
Member

minux commented Feb 4, 2013

Comment 2:

also give a hint about updating swig when swig fails with
"Unrecognized option -intgosize".

Labels changed: added priority-later, go1.1, suggested, removed priority-triage, go1.1maybe.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Feb 5, 2013

Comment 3:

I believe the specific work is, since earlier versions of SWIG don't have
the flag and even the new version defaults to 32 bit int,
1) pass -intgosize 64 when the int size is 64 bits, no option otherwise.
2) perhaps recognize the 'no intgosize flag' error from SWIG and replace it
with something about needing to update to SWIG version >= x.y.z.
Ian, can you confirm this?

@ianlancetaylor
Copy link
Contributor

Comment 4:

The go command should pass the -intgosize option in all cases.  SWIG now requires it.
If SWIG reports "Unrecognized option -intgosize" on stderr, they need to upgrade to SWIG
2.0.9 or later.

@minux
Copy link
Member

minux commented Feb 5, 2013

Comment 5:

so the issue boils down to this:
should we support pre 2.0.9 swig for 32-bit Go 1.1?

@rsc
Copy link
Contributor

rsc commented Feb 5, 2013

Comment 6:

No.

@cookieo9
Copy link
Contributor

Comment 7:

https://golang.org/cl/7331048

@ianlancetaylor
Copy link
Contributor

Comment 8:

This issue was closed by revision 7c79382.

Status changed to Fixed.

@gopherbot gopherbot added fixed Suggested Issues that may be good for new contributors looking for work to do. labels Mar 2, 2013
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
5 participants
@rsc @cookieo9 @minux @ianlancetaylor @gopherbot