Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Add button to show keyboard shortcuts #47552

Closed
silvanocerza opened this issue Aug 5, 2021 · 5 comments
Closed

x/pkgsite: Add button to show keyboard shortcuts #47552

silvanocerza opened this issue Aug 5, 2021 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input
Milestone
pkgsite/2021

Comments

@silvanocerza
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/fmt

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:90.0) Gecko/20100101 Firefox/90.0

Screenshot

Not applicable.

What did you do?

I searched for a button to know which are the keyboards shortcuts.

What did you expect to see?

A button labeled "Keyboard shortcuts" or something similar.

What did you see instead?

Nothing.
@gopherbot gopherbot added this to the Unreleased milestone Aug 5, 2021
@mvdan
Copy link
Member

mvdan commented Aug 5, 2021

You can press ? to see the shortcuts, but I agree it's not easy to discover.

@silvanocerza
Copy link
Author

silvanocerza commented Aug 5, 2021 •
edited

Yes, it's not easy. I found out about it from this comment: #47421 (comment)

@jamalc jamalc added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. UX Issues that involve UXD/UXR input labels Aug 5, 2021
@jamalc jamalc modified the milestones: Unreleased, pkgsite/unplanned Aug 5, 2021
@silvanocerza
Copy link
Author

This seems solved to me, there is a button in the page footer now.

image

@jamalc
Copy link

jamalc commented Jan 14, 2022

Thank you, yes, I'll close this issue.

@jamalc jamalc closed this as completed Jan 14, 2022
@silvanocerza
Copy link
Author

Same thing for #47553.

@golang golang locked and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input
Projects
None yet
Milestone
pkgsite/2021
Development

No branches or pull requests
5 participants
@silvanocerza @mvdan @julieqiu @gopherbot @jamalc