Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: playground has no timezone data #4755

Closed
gopherbot opened this issue Feb 4, 2013 · 20 comments
Closed

website: playground has no timezone data #4755

gopherbot opened this issue Feb 4, 2013 · 20 comments

Comments

@gopherbot
Copy link

by binaryexp:

What steps will reproduce the problem?
http://play.golang.org/p/vKknkh05zg

What is the expected output?
America/New_York

What do you see instead?
UTC
@rsc
Copy link
Contributor

rsc commented Feb 4, 2013

Comment 1:

This is probably working as intended. The playground has no file system access so it
cannot load the files. But perhaps we could fake it. I do miss being able to write
programs demonstrating time zones there.

Labels changed: added priority-someday, removed priority-triage.

Status changed to Accepted.

@bradfitz
Copy link
Contributor

bradfitz commented Feb 4, 2013

Comment 2:

Even without a filesystem, we could just link in the 370 KB timezone.zip file as a
private string in the time package and make a zoneinfo_playground.go which reads from
that?

@gopherbot
Copy link
Author

Comment 3 by binaryexp:

Sounds great. I'm working on integrating timezone functionality into my app, and was
initially a little confused when the playground did not return the expected results.
Having integrated timezones would be a great help when experimenting with the time
package.

@rsc
Copy link
Contributor

rsc commented Mar 12, 2013

Comment 4:

[The time for maybe has passed.]

Labels changed: removed go1.1maybe.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 5:

Labels changed: added go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Sep 10, 2013

Comment 6:

Labels changed: added documentation.

@robpike
Copy link
Contributor

robpike commented Sep 20, 2013

Comment 7:

Issue #6432 has been merged into this issue.

@rsc
Copy link
Contributor

rsc commented Oct 3, 2013

Comment 8:

We have a plan for this but it's not tied to the release.

Labels changed: added priority-later, removed priority-someday, go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 9:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 10:

Labels changed: added release-none, removed go1.3maybe.

@adg
Copy link
Contributor

adg commented Dec 4, 2013

Comment 11:

Labels changed: added repo-playground.

@minux
Copy link
Member

minux commented Feb 27, 2014

Comment 12:

Given that the NaCl-based playground does have (faked) file system access,
I suggest we fix this before 1.3. Seems straightforward to fix.

Labels changed: added release-go1.3, removed priority-later, release-none.

@adg
Copy link
Contributor

adg commented Mar 2, 2014

Comment 13:

Agreed. Now that the NaCl changes are (almost?) merged, it'll be easy for me to include
this in the playground.

Owner changed to @adg.

@rsc
Copy link
Contributor

rsc commented May 19, 2014

Comment 14:

not blocking release

Labels changed: added release-none, removed release-go1.3.

@adg
Copy link
Contributor

adg commented Aug 7, 2014

Comment 15:

The obvious way to fix this is to put /usr/share/zoneinfo into a zip file and use that
as the fake filesystem in each playground nacl binary. That zip file is 1.6M. Not sure
it's worth adding this bloat to every playground executable for such minor benefit.
Thoughts?

@minux
Copy link
Member

minux commented Aug 7, 2014

Comment 16:

we already have $GOROOT/lib/time/zoneinfo.zip (358933 bytes),
but that file isn't compressed.
after compression, its size could be down to 300988 bytes.
(our fake file system for nacl does support compression, only
the time package reader doesn't support compression.)
300KB is probably good enough.

@adg
Copy link
Contributor

adg commented Aug 7, 2014

Comment 17:

I didn't know we had that one. That's much more manageable.

@adg
Copy link
Contributor

adg commented Aug 7, 2014

Comment 18:

Owner changed to @minux.

@minux
Copy link
Member

minux commented Aug 19, 2014

Comment 19:

I've fixed this bug internally, but lacked both
time and required privilege to push it to play.golang.org.
Hand back to adg to (test and) push the fix to production.
Thanks!

Owner changed to @adg.

@adg
Copy link
Contributor

adg commented Aug 19, 2014

Comment 20:

Tested and deployed. Thanks Minux! =D

Status changed to Fixed.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants