Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestCancelRequestWhenSharingConnection can cause port exhaustion, leading to frequent test failures with "Only one usage of each socket address" on windows-amd64-longtest [1.15 backport] #47534

Closed
gopherbot opened this issue Aug 4, 2021 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

@neild requested issue #47016 to be considered for backport to the next 1.15 minor release.

@gopherbot please open backport issues.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 4, 2021
@gopherbot gopherbot added this to the Go1.15.16 milestone Aug 4, 2021
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Aug 4, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/339829 mentions this issue: [release-branch.go1.15] net/http: speed up and deflake TestCancelRequestWhenSharingConnection

@dmitshur dmitshur changed the title net/http: frequent test failures with "Only one usage of each socket address" on windows-amd64-longtest [1.15 backport] net/http: TestCancelRequestWhenSharingConnection can cause port exhaustion, leading to frequent test failures with "Only one usage of each socket address" on windows-amd64-longtest [1.15 backport] Aug 4, 2021
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 4, 2021
@gopherbot
Copy link
Author

Closed by merging e90f402 to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Aug 4, 2021
…estWhenSharingConnection

This test made many requests over the same connection for 10
seconds, trusting that this will exercise the request cancelation
race from #41600.

Change the test to exhibit the specific race in a targeted fashion
with only two requests.

Fixes #47534.
Updates #41600.
Updates #47016.

Change-Id: If99c9b9331ff645f6bb67fe9fb79b8aab8784710
Reviewed-on: https://go-review.googlesource.com/c/go/+/339594
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
(cherry picked from commit 6e73886)
Reviewed-on: https://go-review.googlesource.com/c/go/+/339829
@golang golang locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants