x/exp/cmd/gorelease: cannot verify consistency of existing tag #47532
Labels
modules
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
|
CC @jayconrod @jadekler |
|
This is an important use case for gomoddiff, when we do eventually do that (#46371). gomoddiff will compare two versions, usually but not necessarily from the same module, and it will report whether those versions are consistent with semver (at least as far as it can tell from the public API). We should make sure that when gomoddiff is given only one version, it automatically compares against the next lower version. |
jayconrod
added
modules
Tools
dmitshur
added
the
NeedsInvestigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
Yes
What did you do?
I use
goreleaselocally, it's a great tool to automatically apply semver rules and suggest new version numbers.What did you expect to see?
In addition to that, I would like to use it on CI (specifically: every time a new
v*tag is pushed) in order to verify that this tag is consistent with the semantic versioning rules. This would allow us to catch cases where contributors forgot to rungoreleasebefore tagging a new release, and quickly act to avoid breaking downstream users when we used the wrong version number.What did you see instead?
There's no way to verify an existing version using
gorelease. Runninggoreleaseon the most recent tag (v0.x.y) will just returnv0.x.y+1, running it using the-base=v0.x.y-1results in the error message "Can only suggest a release version when compared against the most recent version of this major: v0.x.y".The text was updated successfully, but these errors were encountered: