Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: unnecessary warning for any function named error #4753

Closed
dominikh opened this issue Feb 4, 2013 · 2 comments
Closed

cmd/vet: unnecessary warning for any function named error #4753

dominikh opened this issue Feb 4, 2013 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.1

Comments

@dominikh
Copy link
Member

dominikh commented Feb 4, 2013 

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. Run go vet on http://play.golang.org/p/hMdAsR9Bcv

What is the expected output?
No output

What do you see instead?
foo.go:17:2: no args in error call
foo.go:18:2: no args in ErRoR call
foo.go:19:2: no args in ERROR call

Which version are you using?  (run 'go version')
go version devel +e2f9b9a58240 Mon Feb 04 00:21:44 2013 -0500 linux/amd64

Please provide any additional information below.
issue #4598 addressed this for the very specific case of err.Error(), but go vet
shouldn't complain about any of these cases, because they're user-defined functions and
there's no reason they should require arguments.
@minux
Copy link
Member

minux commented Feb 6, 2013

Comment 1:

must wait for go/types.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@robpike
Copy link
Contributor

robpike commented Feb 23, 2013

Comment 2:

This issue was closed by revision 4434212.

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.1
Development

No branches or pull requests
5 participants
@dominikh @rsc @minux @robpike @gopherbot