Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: occasional flakes in TestReloadInvalidMetadata #47508

Closed
findleyr opened this issue Aug 2, 2021 · 1 comment
Closed

x/tools/gopls: occasional flakes in TestReloadInvalidMetadata #47508

findleyr opened this issue Aug 2, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.2

Comments

@findleyr
Copy link
Contributor

findleyr commented Aug 2, 2021

Reported on Slack by @leitzler: it looks like TestReloadInvalidMetadata is flaky, though very rarely relative to some of the flakes we've seen in the past.

Notably it failed on Kokoro, where flakes due to timing seem to occur less frequently:
https://source.cloud.google.com/results/invocations/4b992213-48f2-4dfa-91a2-30d9dc3f8600/log

Trybot flakes:
2021-08-02T20:16:24-45eff0f/linux-ppc64le-buildlet
2021-07-29T13:34:27-ab1fe72/dragonfly-amd64
2021-07-15T13:35:41-6e9046b/android-386-emu
2021-07-13T16:40:23-8e85a28/freebsd-arm64-dmgk
2021-07-13T13:36:40-d36a54b/freebsd-arm64-dmgk
2021-07-10T00:32:22-5b540d3/dragonfly-amd64

CC @stamblerre
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Aug 2, 2021
@gopherbot gopherbot added this to the Unreleased milestone Aug 2, 2021
@findleyr findleyr modified the milestones: Unreleased, gopls/unplanned Aug 3, 2021
@stamblerre stamblerre self-assigned this Aug 6, 2021
@gopherbot
Copy link

Change https://golang.org/cl/342674 mentions this issue: internal/lsp/cache: fix flakiness of load progress reports

gopherbot pushed a commit to golang/tools that referenced this issue Aug 17, 2021
@stamblerre
internal/lsp/cache: fix flakiness of load progress reports
96f147c 
I'm not sure why there was a goroutine in the defer here, but I think
this should fix the flakiness of this test. I wasn't able to reproduce
the flake myself locally however, so I couldn't confirm. I'll leave the
issue open until it stops happening.

For golang/go#47508

Change-Id: Ie9fdc68d70fe1634c3ad001441cf3ce0d2693d17
Reviewed-on: https://go-review.googlesource.com/c/tools/+/342674
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.2
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @findleyr