Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: unify header between build and status pages #47477

Closed
dmitshur opened this issue Jul 30, 2021 · 2 comments
Closed

x/build/cmd/coordinator: unify header between build and status pages #47477

dmitshur opened this issue Jul 30, 2021 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 30, 2021 •
edited

The build dashboard is merging into the coordinator codebase in #34744, so maybe we should unify the header. It would help navigation between the build dashboard and the farmer status page, especially during local development.

We currently have:

And:

Perhaps something like this can work as a starting point.

CC @golang/release.
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 30, 2021
@dmitshur dmitshur added this to the Unreleased milestone Jul 30, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 30, 2021
@dmitshur dmitshur self-assigned this Jul 30, 2021
@dmitshur
Copy link
Contributor Author

dmitshur commented Aug 5, 2021

I came up with a simpler next step I'm happier with. Instead of adding a new "Coordinator" button, I'll just linkify the existing "Go Build Coordinator" text to take one to cmd/coordinator's "home" page.

simple.unified.header.mov

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 5, 2021
@dmitshur dmitshur added this to In Progress in Go Release Team Aug 5, 2021
@gopherbot
Copy link

Change https://golang.org/cl/340116 mentions this issue: cmd/coordinator: unify headers visually

Go Release Team automation moved this from In Progress to Done Aug 10, 2021
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot