New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: don't store retracted versions #47461
Comments
Change https://golang.org/cl/338330 mentions this issue: |
Will it still at least show a landing page indicating that the requested version is retracted? Retracted versions can still be cached and fetched from a proxy, and users can continue to build existing modules against them — I feel like we ought to at least leave some kind of breadcrumb to acknowledge that pkgsite knows about the existence of the thing they're asking for, even if it doesn't give any further details about the retracted contents. |
Can the page simply say "This version is retracted" and link to the latest version? |
That seems fine to me. That said, thinking about this some more: users can continue to use retracted versions, so maybe it's worth indexing them if they are requested explicitly. For example: suppose that module |
Good point, Bryan. We will keep processing retracted versions. (But we'll continue omitting them from search results.) |
Is that behavior live? https://beta.pkg.go.dev/search?q=rerpc shows |
Thanks for catching. That's an un-done TODO in the code. Tracked at #47590. |
Pkgsite will never display a retracted version as the latest version of a module. But it will process a retracted version, and it won't remove a version if it is later retracted. The page for a retracted version can be visited by providing the version number, and the version may appear in search if it was later retracted.
pkgsite should not process retracted versions, and should remove a version when it discovers it is retracted.
The text was updated successfully, but these errors were encountered: