Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: create production and staging environments #47407

Open
1 of 3 tasks
toothrot opened this issue Jul 26, 2021 · 5 comments
Open
1 of 3 tasks

x/build/cmd/relui: create production and staging environments #47407

toothrot opened this issue Jul 26, 2021 · 5 comments
Assignees
@toothrot
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release Team
Milestone
Unreleased

Comments

@toothrot
Copy link
Contributor

toothrot commented Jul 26, 2021 •
edited

  • Staging
  • Production
  • TBD?

Blocked by #47401
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 26, 2021
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jul 26, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jul 26, 2021
@cagedmantis cagedmantis added this to Planned in Go Release Team Jul 27, 2021
@toothrot toothrot self-assigned this Nov 22, 2021
@gopherbot
Copy link

Change https://golang.org/cl/369254 mentions this issue: cmd/relui: add cloud build configuration

gopherbot pushed a commit to golang/build that referenced this issue Jan 14, 2022
@toothrot
cmd/relui: add cloud build configuration
dbf8e0d 
Add cloud build configuration for running integration tests for relui.

For golang/go#47407

Change-Id: Id06846f4ecd7129b112b5f130cb72b257cc6898a
Reviewed-on: https://go-review.googlesource.com/c/build/+/369254
Trust: Alex Rakoczy <alex@golang.org>
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@dmitshur
Copy link
Contributor

dmitshur commented Jan 20, 2022 •
edited

TBD?

Edit: I originally suggested a "dry-run" semi-environment, but by now think that needs to be a separate mode. It probably deserves its own issue as this issue is about setting up actual running environments, so I'll withdraw the comment for now.

Original comment

In addition to production and staging, I suggest having a third semi-environment, "dry-run mode". It would be intended for local execution and wouldn't need to be deployed anywhere. It would be similar to how releasebot behaves with -dry-run flag: run as much of the same code as possible but skip all external effects.

We can change the color scheme of the header for all 3 modes so they're easy to tell apart, e.g., something like:

image

image

image

@dmitshur
Copy link
Contributor

dmitshur commented Feb 3, 2022 •
edited

@toothrot Should the "Production" checkbox be checked now, given #47401 is resolved and we have https://build.golang.org/releases/?

I'm about ready to send CLs that'll resolve #47402. That means running cmd/relui locally would allow production workflows to be run (and no other option, unless code is modified locally), unless we make progress on this issue to allow selecting a non-production environment or mode.

I don't know what we want the long-term solution for this to be, perhaps that needs more discussion. As an intermediate step here to enable progress, are you okay with reusing the existing x/build/buildenv package and its idioms for cmd/relui, or would you prefer a different path instead?

(If it is a goal not to use x/build/buildenv in cmd/relui, we can instead add an explicit flag that controls where the Twitter API credentials are fetched from, and control its prod value in deployment-prod.yaml.)

@dmitshur dmitshur mentioned this issue Feb 9, 2022
Closed
@dmitshur
Copy link
Contributor

dmitshur commented Feb 9, 2022 •
edited

I don't know what we want the long-term solution for this to be, perhaps that needs more discussion.

I've had a chance to cover this with @heschi today, and I think we found agreement on something with good properties that might not take too much time to begin with. In that case, the intermediate step of reusing buildenv won't be worthwhile. I opened #51122 as the tracking issue for it.

@gopherbot
Copy link

Change https://go.dev/cl/410235 mentions this issue: cmd/relui: upgrade to Go 1.18 and Debian 11

gopherbot pushed a commit to golang/build that referenced this issue Jun 7, 2022
@toothrot
cmd/relui: upgrade to Go 1.18 and Debian 11
65faff0 
Updates golang/go#47407

Change-Id: I4a07a18e817ff5deac8de97779d2957396e053f7
Reviewed-on: https://go-review.googlesource.com/c/build/+/410235
Run-TryBot: Alex Rakoczy <alex@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
@dmitshur dmitshur mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toothrot toothrot

Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Status: Planned
Go Release Team
Planned
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot