-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/relui: send release notification email #47405
Comments
Change https://golang.org/cl/382935 mentions this issue: |
Previously, the tweet tasks fetched Twitter API credentials implicitly from the environment, and a dryRun bool parameter was used to disable the task from actually posting a tweet (useful for running tests). This doesn't scale well to being able to supply different credentials, which is needed to be able to run the task in a staging environment, using a staging/test set of credentials. Create an ExternalConfig struct for providing secrets for external services that tasks need to interact with, making this more explicit. This will be used by relui in its upcoming "create tweet" workflows. Update the MailDLCL task analogously to accept the new ExternalConfig parameter, making it more testable and dry-run-capable in the process. Also switch to using *workflow.TaskContext (pointer, not value), since that's what the x/build/internal/workflow package expects. For golang/go#47402. Updates golang/go#47405. Change-Id: I40f0144a57ca0031840fbd1303ab56ac3fefc6c6 Reviewed-on: https://go-review.googlesource.com/c/build/+/382935 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Alex Rakoczy <alex@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
This comment was marked as resolved.
This comment was marked as resolved.
Change https://go.dev/cl/404454 mentions this issue: |
Previously, it was only possible to create workflow parameters with the implicit "string" type hard-coded. Some workflows we're creating either require or will benefit from more flexibility in parameter types (slices of strings, single-line vs multi-line strings, and so on). It was also not yet possible to associate metadata to parameters (such as documentation, example values). This change implements that flexibility for workflow parameters, and uses it to better document the existing Twitter workflows. The next change will add a workflow that uses new slice types. For simplicity and clarity reasons, all parameter information is contained in one place in the workflow.Parameter struct, including some fields that control the HTML presentation of said parameters, instead of trying to factor out HTML bits into the relui package and creating a bridge between the two. Also type check in more stages of the workflow processing. For golang/go#47405. Fixes golang/go#51191. Change-Id: Ia805b3b355e65fcbf2397ad21800da448ccb826a Reviewed-on: https://go-review.googlesource.com/c/build/+/404454 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Change https://go.dev/cl/411575 mentions this issue: |
Change https://go.dev/cl/412754 mentions this issue: |
This CL contains just the templates and test data for review convenience. The next CL in the stack holds the implementation. The email templates have a MIME-style header with a Subject key, which is used to determine the email subject, and the rest is the email body in Markdown format. While the announcement emails have been generated from templates for a while, there was variation in minor formatting and wording over the years. These templates are converted to Markdown and attempt to not to deviate from the average past announcements too much while correcting minor inconsistencies. Making larger changes can be considered later. It should be easier now that this task is driven by templates without outsourcing the responsibility of HTML formatting and editing to the human senders. For golang/go#47405. Fixes golang/go#47404. Change-Id: Ie04d94b35ce1b5d111eeb1b0b076c034ba3f4dcb Reviewed-on: https://go-review.googlesource.com/c/build/+/412754 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Change https://go.dev/cl/413074 mentions this issue: |
I don't know why I added commas, maybe thinking of JSON, but they cause a YAML parse error so we can't keep them. Also get rid of a misplaced word in a log message. For golang/go#47405. Change-Id: I1072a4c4f563704345100620c5e1fdfdf7df3dcd Reviewed-on: https://go-review.googlesource.com/c/build/+/413074 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Alex Rakoczy <alex@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
The release notification task should send an appropriate announcement email to golang-nuts@googlegroups.com and BCC both golang-announce@googlegroups.com and golang-dev@googlegroups.com.
This email should come from an @golang.org account.
The link to the announcement email needs to be stored as an output on the task to be referenced by following tasks (the tweet).
Sending options:
See #47404 for draft.
The text was updated successfully, but these errors were encountered: