Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect: Slice documentation should note that an array must be addressable #4736

Closed
kortschak opened this issue Jan 31, 2013 · 2 comments
Closed
Milestone

Comments

@kortschak
Copy link
Contributor

What steps will reproduce the problem?
If possible, include a link to a program on play.golang.org.
1. Navigate to http://tip.golang.org/pkg/reflect/#Value.Slice

What is the expected output?
Inclusion of a notice that Slice cannot be called on a unaddressable array
reflect.Value. 

What do you see instead?
No such warning.

Which compiler are you using (5g, 6g, 8g, gccgo)?
6g

Which operating system are you using?
Linux

Which version are you using?  (run 'go version')
go1.0.3/tip

Please provide any additional information below.
@kortschak
Copy link
Contributor Author

Comment 1:

Proposed CL: https://golang.org/cl/7239045

@rsc
Copy link
Contributor

rsc commented Feb 1, 2013

Comment 2:

This issue was closed by revision 11d16dc.

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants