go/types: change in embedded type ordering on dev.typeparams branch #47352
Labels
FrozenDueToAge
NeedsDecision
Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Comments
mdempsky
added
the
NeedsDecision
|
If this is an isolated incident, I vote for fixing the test. The print output is still deterministic, it's just that now it's based on source order rather than sort order. We could just sort when printing, but then the output doesn't match the API order. We could keep the (original) sorted order, but that would require a bit more work when sorting (we need to sort positions as well). It doesn't seem worth the effort. The |
|
Any further comments on this? If not, I'll change the test. |
|
Please change the test - this seems the easiest way forward. |
|
OK. Close the bug if you like. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The test program at https://play.golang.org/p/O5DRq3UlQRa currently prints
type x.J interface{x.I; error}But on dev.typeparams, since fe4f134, it prints
type x.J interface{error; x.I}.This broke a Google-internal test. I'm okay with fixing the test, but @findleyr suggested that maybe we should restore the original sort order. Filing the issue to decide.
/cc @griesemer @dominikh
The text was updated successfully, but these errors were encountered: