Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "go list -f '{{.Stale}}'" stack overflow with cyclic imports [1.15 backport] #47347

Closed
gopherbot opened this issue Jul 22, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone

Comments

@gopherbot
Copy link

@stamblerre requested issue #25830 to be considered for backport to the next 1.15 minor release.

@gopherbot please consider this for backport to 1.16 and 1.15

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 22, 2021
@gopherbot gopherbot added this to the Go1.15.15 milestone Jul 22, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/336669 mentions this issue: [release-branch.go1.15] cmd/go/internal/load: always set IsImportCycle when in a cycle

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jul 22, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 22, 2021
@bcmills
Copy link
Contributor

bcmills commented Jul 22, 2021

According to @stamblerre we're still getting a nonzero rate of reports for this crash among gopls users.

The fix CL is small (and low-risk) and the TryBots are happy with it (and the corresponding new test), so this seems worth backporting.

@gopherbot
Copy link
Author

Closed by merging b81d75f to release-branch.go1.15.

gopherbot pushed a commit that referenced this issue Aug 2, 2021
…e when in a cycle

When hitting an import cycle in reusePackage, and there is already
an error set, make sure IsImportCycle is set so that we don't
end up stuck in a loop.

Updates #25830
Fixes #47347

Change-Id: Iba966aea4a637dfc34ee22782a477209ac48c9bd
Reviewed-on: https://go-review.googlesource.com/c/go/+/301289
Trust: Roland Shoemaker <roland@golang.org>
Run-TryBot: Roland Shoemaker <roland@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit cdd08e6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/336669
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Development

No branches or pull requests

3 participants