Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: stale go-source meta tag information #47335

Closed
myitcv opened this issue Jul 22, 2021 · 2 comments
Closed

x/pkgsite: stale go-source meta tag information #47335

myitcv opened this issue Jul 22, 2021 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite

Comments

@myitcv
Copy link
Member

myitcv commented Jul 22, 2021

What is the URL of the page with the issue?

https://pkg.go.dev/cuelang.org/go/cue#Attribute

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.107 Safari/537.36

Screenshot

n/a

What did you do?

Clicked on the Attribute identifier to jump to the source code.

What did you expect to see?

To navigate to the GitHub-based source code browser, specifically https://github.com/cue-lang/cue/blob/master/cue/attribute.go#L113.

What did you see instead?

A broken GerritHub link at https://review.gerrithub.io/cue-lang/cue/+/master/cue/attribute.go.

The go-source meta tag has been updated for cuelang.org/go, but I'm unclear of the period of cache refresh for such meta tags, or how to trigger/force a refresh:

$ curl -s https://cuelang.org/go/cue?go-get=1 | grep go-source
<meta name="go-source" content="cuelang.org/go https://github.com/cue-lang/cue https://github.com/cue-lang/cue/blob/master{/dir} https://github.com/cue-lang/cue/blob/master{/dir}/{file}#L{line}">
@myitcv myitcv added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite labels Jul 22, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2021
@julieqiu
Copy link
Member

I manually refreshed the source links for https://pkg.go.dev/cuelang.org/go. Closing as a duplicate of #46203.

@myitcv
Copy link
Member Author

myitcv commented Jul 22, 2021

Oops, sorry, missed the dup. Thanks for fixing, @julieqiu!

@golang golang locked and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

3 participants