Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile: use GOOS=ios and remove the build tag ios usages #47238

Closed
hajimehoshi opened this issue Jul 16, 2021 · 5 comments
Closed

x/mobile: use GOOS=ios and remove the build tag ios usages #47238

hajimehoshi opened this issue Jul 16, 2021 · 5 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@hajimehoshi
Copy link
Member

hajimehoshi commented Jul 16, 2021 •
edited

This is a proposal of refactoring. I propose to replace the current build tag ios usages with specifying GOOS=ios. This change means that Go 1.16 or newer will be required for gomobile. So, I'm fine if we have to wait more (e.g., Go 1.17 is released)

Background: GOOS=ios was introduced at Go 1.16. Before this, gomobile used a build tag ios for iOS projects. In Go 1.16 and newer, standard libraries have *_ios.go files, and apparently they also specify // +build ios explicitly at the same time. Then, we don't have an urgent issue around this.

@hyangah, @ydnar, What do you think?
@gopherbot gopherbot added the mobile Android, iOS, and x/mobile label Jul 16, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jul 16, 2021
@ydnar
Copy link

ydnar commented Jul 16, 2021

Sure, I think it makes sense.

Would you want the current iOS tests to pass as well?

It would probably need some additional updates, and ideally macOS CI so it doesn't continue to bit-rot.

@cherrymui cherrymui added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jul 16, 2021
@cherrymui
Copy link
Member

cc @eliasnaur

@hajimehoshi hajimehoshi mentioned this issue Jul 19, 2021
Closed
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Aug 31, 2021
@dmitshur
Copy link
Contributor

Now that Go 1.17 is released (and thus 1.15 has become unsupported), there shouldn't be a reason not to do this. Also see discussion in #47952.

@gopherbot
Copy link

Change https://golang.org/cl/346150 mentions this issue: cmd/gomobile: use GOOS=ios for iOS builds

@gopherbot
Copy link

Change https://golang.org/cl/346151 mentions this issue: all: use Apple Development over iPhone Developer

gopherbot pushed a commit to golang/mobile that referenced this issue Aug 31, 2021
@changkun @hajimehoshi
cmd/gomobile: use Apple Development over iPhone Developer
18b1a0c 
Apple Development Program was introduced in WWDC2015. It is 2021 today,
and there should have no possibility to use iPhone Developer certificate
for code signing.

This CL replaces "iPhone Developer" by "Apple Development" so that
cmd/gomobile can use the correct certificate to sign the building
application. Otherwise, gomobile throws an error gomobile: failed to
pull the signing certificate to determine your team ID: exit status 44

Updates golang/go#47238

Change-Id: Ia48c03ff7cda39a95159e0f77e7ba7042776f9ef
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/346151
Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Hajime Hoshi <hajimehoshi@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Hajime Hoshi <hajimehoshi@gmail.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@hajimehoshi @ydnar @dmitshur @gopherbot @cherrymui