Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/race: tests do not compile on Windows, spew many messages #4721

Closed
alexbrainman opened this issue Jan 29, 2013 · 6 comments
Closed

Comments

@alexbrainman
Copy link
Member

What steps will reproduce the problem?
go test -race -short std

What is the expected output?
no WARINING messages

What do you see instead?
see attached

Please use labels and text to provide additional information.
hg id
601795ce6319+ tip

Attachments:

  1. alex.txt (263858 bytes)
@alberts
Copy link
Contributor

alberts commented Jan 29, 2013

Comment 1:

I think I've run into this before on Linux, but I don't remember exactly what caused it.
I vaguely remember that there was something wrong with the way the test was being run,
and there wasn't actually a race. Might be worth a quick look through the test code.

@remyoudompheng
Copy link
Contributor

Comment 2:

It's not a data race, it's a compilation failure. The error reporting could be improved.
From your log:
=== RUN TestNoRaceCgoSync
# command-line-arguments
cgo_test_main.go:7:21: fatal error: pthread.h: No such file or directory
compilation terminated.

@alexbrainman
Copy link
Member Author

Comment 3:

Thank you for the input. I do not have time to look at it now. I just reported it for
what I saw, so we do not forget. It shouldn't fail the way it did, regardless of the
reason.
Alex

@remyoudompheng
Copy link
Contributor

Comment 4:

It prints the output of the failed test: it was an improvement over the previous
situation (compilation failures were silently ignored), see
http://code.google.com/p/go/source/detail?r=a298f2d
We would have a separate the relevant failure output.

@dvyukov
Copy link
Member

dvyukov commented Jan 29, 2013

Comment 5:

Labels changed: added priority-later, racedetector, removed priority-triage, go1.1.

@dvyukov
Copy link
Member

dvyukov commented Feb 5, 2013

Comment 6:

This issue was closed by revision 6b1b613.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants