Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: do not accept generic features unless -lang is go1.18 or greater #47205

Closed
griesemer opened this issue Jul 14, 2021 · 2 comments
Closed
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@griesemer
Copy link
Contributor

Reminder issue.
This would also apply to implicit instantiation of functions through type inference.

cc: @findleyr, @mdempsky, @ianlancetaylor

@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 14, 2021
@griesemer griesemer added this to the Go1.18 milestone Jul 14, 2021
@griesemer griesemer self-assigned this Jul 14, 2021
@griesemer
Copy link
Contributor Author

This has been fixed for types2 through CL 344871. It can be fixed for go/types by porting that CL.

@griesemer griesemer assigned findleyr and unassigned griesemer Aug 26, 2021
@griesemer griesemer changed the title go/types, types2: do not accept generic features unless -lang is go1.18 or greater go/types: do not accept generic features unless -lang is go1.18 or greater Aug 26, 2021
@odeke-em
Copy link
Member

I am happy to report that @findleyr fixed this in CL https://go-review.googlesource.com/c/go/+/346433 aka commit b93581e but we didn't catch that this issue had been opened 6 days earlier. Closing it but please feel free to correct me if am wrong. Thank you for the awesome and hard work @findleyr and @griesemer!

@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants