Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: make.bash --no-clean fails when compilation target doesn't support regabi #47204

Closed
rhysh opened this issue Jul 14, 2021 · 12 comments
Closed
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@rhysh
Copy link
Contributor

rhysh commented Jul 14, 2021

What version of Go are you using (go version)?

$ go version
go version go1.17rc1 darwin/amd64
$ go version
go version go1.16.6 darwin/amd64
$ go version
go version devel go1.17-60ddf42b46 Wed Jul 14 17:25:06 2021 +0000 darwin/amd64

Does this issue reproduce with the latest release?

This problem is present in go1.17rc1 and tip. It is not present in go1.16.6.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/rhys/Library/Caches/go-build"
GOENV="/Users/rhys/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/rhys/go/pkg/mod"
GONOPROXY="*"
GONOSUMDB="*"
GOOS="darwin"
GOPATH="/Users/rhys/go"
GOPRIVATE="*"
GOPROXY="direct"
GOROOT="/usr/local/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="devel go1.17-60ddf42b46 Wed Jul 14 17:25:06 2021 +0000"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/49/zmds5zsn75z1283vtzxyfr5hj7yjq4/T/go-build4254228305=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

$ cd ./src
$ ./make.bash
$ GOOS=linux GOARCH=386 ./make.bash --no-clean

What did you expect to see?

$ go version
go version go1.16.6 darwin/amd64

$ ./make.bash
Building Go cmd/dist using /Users/rhys/go/version/go1.4. (go1.4-bootstrap-20170531 darwin/amd64)
Building Go toolchain1 using /Users/rhys/go/version/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for darwin/amd64.
---
Installed Go for darwin/amd64 in /usr/local/go
Installed commands in /usr/local/go/bin

$ GOOS=linux GOARCH=386 ./make.bash --no-clean
Building Go cmd/dist using /Users/rhys/go/version/go1.4. (go1.4-bootstrap-20170531 darwin/amd64)
Building Go toolchain1 using /Users/rhys/go/version/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for host, darwin/amd64.
Building packages and commands for target, linux/386.
---
Installed Go for linux/386 in /usr/local/go
Installed commands in /usr/local/go/bin

What did you see instead?

$ go version
go version devel go1.17-60ddf42b46 Wed Jul 14 17:25:06 2021 +0000 darwin/amd64

$ ./make.bash
Building Go cmd/dist using /Users/rhys/go/version/go1.4. (go1.4-bootstrap-20170531 darwin/amd64)
Building Go toolchain1 using /Users/rhys/go/version/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for darwin/amd64.
---
Installed Go for darwin/amd64 in /usr/local/go
Installed commands in /usr/local/go/bin

$ GOOS=linux GOARCH=386 ./make.bash --no-clean
Building Go cmd/dist using /Users/rhys/go/version/go1.4. (go1.4-bootstrap-20170531 darwin/amd64)
Building Go toolchain1 using /Users/rhys/go/version/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
/usr/local/go/src/cmd/go/main.go:10:2: import /usr/local/go/pkg/darwin_amd64/context.a: object is [go object darwin amd64 devel go1.17-60ddf42b46 Wed Jul 14 17:25:06 2021 +0000 X:regabiwrappers,regabig,regabireflect,regabidefer,regabiargs
] expected [go object darwin amd64 devel go1.17-60ddf42b46 Wed Jul 14 17:25:06 2021 +0000 X:
]

go tool dist: FAILED: /usr/local/go/pkg/tool/darwin_amd64/compile -std -pack -o /var/folders/49/zmds5zsn75z1283vtzxyfr5hj7yjq4/T/go-tool-dist-791323986/cmd/go/_go_.a -p main -importcfg /var/folders/49/zmds5zsn75z1283vtzxyfr5hj7yjq4/T/go-tool-dist-791323986/cmd/go/importcfg /usr/local/go/src/cmd/go/alldocs.go /usr/local/go/src/cmd/go/go11.go /usr/local/go/src/cmd/go/main.go: exit status 2
Building Go toolchain2 using go_bootstrap and Go toolchain1.
go tool dist: FAILED: /usr/local/go/pkg/tool/darwin_amd64/go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: fork/exec /usr/local/go/pkg/tool/darwin_amd64/go_bootstrap: no such file or directory
@rhysh
Copy link
Contributor Author

rhysh commented Jul 14, 2021

FWIW, git bisect points to fd3612e as the first bad commit.

@bcmills (or @mdempsky ), is this part of the build your domain?

$ git bisect start
$ git bisect bad origin/master
$ git bisect good $(git merge-base origin/master go1.16.6)
[snip]
$ git bisect run bash -c 'cd ./src ; ./make.bash || exit 125 ; GOOS=linux GOARCH=386 ./make.bash --no-clean'
[snip]
fd3612e4339d10a0e02571a8e43868d569b11a9f is the first bad commit
[snip]
bisect run success

@bcmills bcmills added this to the Go1.17 milestone Jul 14, 2021
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 14, 2021
@mdempsky mdempsky self-assigned this Jul 14, 2021
@mdempsky
Copy link
Member

I'm still investigating this and don't have any obvious/simple fix just yet. Before I dig too much further, what's the use case for make.bash --no-clean? I feel like it used to be needed for getting a cross-compiler toolchain setup, but the toolchain has supported cross-compiling as a runtime knob for a while now. Is simply dropping --no-clean an option here? If not, what's the present day need for it still?

/cc @ianlancetaylor

@mrutter-amzn
Copy link

The use-case appears to have been for getting the cross-compiler toolchain setup. Removing the flag from our setup appears to be an option.

@mdempsky
Copy link
Member

@mrutter-amzn Thanks. To clarify, you're talking about the same setup that @rhysh originally reported about? Or a separate one?

@ianlancetaylor
Copy link
Contributor

The --no-clean option is from https://golang.org/cl/5673056 which says

Makes it possible to run

GOARCH=amd64 make.bash
GOARCH=386 make.bash --no-clean

to avoid deleting some of the work done by the first one.

So basically I think it's to make the build faster. And it may be the case that it does make the build slightly faster even today, as it doesn't have to relink the host binaries.

I assume the problem with --no-clean here is the explicit GOEXPERIMENT=none added by cmdbootstrap. If we left that out I would expect that things would work, or, at least, that we wouldn't have this particular problem. That was added by https://golang.org/cl/302050. CC @aclements

@rhysh
Copy link
Contributor Author

rhysh commented Jul 15, 2021

Yes, same issue. The build script @mrutter-amzn and I are debugging has specified that flag for several years, but removing it allows the build to succeed—and for the resulting toolchain to work as we need. I don't know how much duplicate compile/link time we'd save if the flag worked.

@mdempsky
Copy link
Member

I tried removing GOEXPERIMENT=none, and instead the resulting go_bootstrap binary crashes:

Building Go cmd/dist using /usr/local/google/home/mdempsky/wd/go1.4. (go1.4.3 linux/amd64)
Building Go toolchain1 using /usr/local/google/home/mdempsky/wd/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
unexpected fault address 0x9a7d0
fatal error: fault
[signal SIGSEGV: segmentation violation code=0x1 addr=0x9a7d0 pc=0x4c9fb4]

goroutine 17 [running]:
runtime.throw({0x7eacb7, 0x7eff9e39be30})
	/usr/local/google/home/mdempsky/wd/go-fresh/src/runtime/panic.go:1198 +0x71 fp=0xc00009a690 sp=0xc00009a660 pc=0x4334f1
runtime.sigpanic()
	/usr/local/google/home/mdempsky/wd/go-fresh/src/runtime/signal_unix.go:742 +0x2f6 fp=0xc00009a6e0 sp=0xc00009a690 pc=0x448eb6
os.(*Process).Release(0xc0002b6840)
	/usr/local/google/home/mdempsky/wd/go-fresh/src/os/exec.go:116 +0x14 fp=0xc00009a710 sp=0xc00009a6e0 pc=0x4c9fb4
runtime.call32(0x0, 0x8264d0, 0xc00033a020, 0x20, 0x20, 0x20, 0xc00009a770)
	/usr/local/google/home/mdempsky/wd/go-fresh/src/runtime/asm_amd64.s:626 +0x49 fp=0xc00009a740 sp=0xc00009a710 pc=0x461aa9
runtime.runfinq()
	/usr/local/google/home/mdempsky/wd/go-fresh/src/runtime/mfinal.go:245 +0x389 fp=0xc00009a7e0 sp=0xc00009a740 pc=0x418349
runtime.goexit()
	/usr/local/google/home/mdempsky/wd/go-fresh/src/runtime/asm_amd64.s:1581 +0x1 fp=0xc00009a7e8 sp=0xc00009a7e0 pc=0x4635a1
created by runtime.createfing
	/usr/local/google/home/mdempsky/wd/go-fresh/src/runtime/mfinal.go:157 +0x45

...

Are there extra steps that cmd/dist needs to perform when compiling/linking binaries that use regabi?

@mdempsky
Copy link
Member

Yes, same issue. The build script @mrutter-amzn and I are debugging has specified that flag for several years, but removing it allows the build to succeed—and for the resulting toolchain to work as we need. I don't know how much duplicate compile/link time we'd save if the flag worked.

SGTM, thanks.

FYI, my recommendation would be to just run "make.bash" once normally to build the host tools, and then run "GOARCH=... GOOS=... go install std" to pre-compile the standard library for each target platform that you're interested in. That should be even faster than make.bash --no-clean ever was.

With Go 1.16.6:

$ time sh -c "( export GOROOT_BOOTSTRAP=$HOME/wd/go1.4 && ./make.bash && GOARCH=386 ./make.bash --no-clean )"
Building Go cmd/dist using /usr/local/google/home/mdempsky/wd/go1.4. (go1.4.3 linux/amd64)
Building Go toolchain1 using /usr/local/google/home/mdempsky/wd/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for linux/amd64.
---
Installed Go for linux/amd64 in /usr/local/google/home/mdempsky/wd/go-fresh
Installed commands in /usr/local/google/home/mdempsky/wd/go-fresh/bin
Building Go cmd/dist using /usr/local/google/home/mdempsky/wd/go1.4. (go1.4.3 linux/amd64)
Building Go toolchain1 using /usr/local/google/home/mdempsky/wd/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for host, linux/amd64.
Building packages and commands for target, linux/386.
---
Installed Go for linux/386 in /usr/local/google/home/mdempsky/wd/go-fresh
Installed commands in /usr/local/google/home/mdempsky/wd/go-fresh/bin

real	1m50.453s
user	6m47.415s
sys	0m57.323s


$ time sh -c "( export GOROOT_BOOTSTRAP=$HOME/wd/go1.4 && ./make.bash && GOARCH=386 ./make.bash )"
Building Go cmd/dist using /usr/local/google/home/mdempsky/wd/go1.4. (go1.4.3 linux/amd64)
Building Go toolchain1 using /usr/local/google/home/mdempsky/wd/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for linux/amd64.
---
Installed Go for linux/amd64 in /usr/local/google/home/mdempsky/wd/go-fresh
Installed commands in /usr/local/google/home/mdempsky/wd/go-fresh/bin
Building Go cmd/dist using /usr/local/google/home/mdempsky/wd/go1.4. (go1.4.3 linux/amd64)
Building Go toolchain1 using /usr/local/google/home/mdempsky/wd/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for host, linux/amd64.
Building packages and commands for target, linux/386.
---
Installed Go for linux/386 in /usr/local/google/home/mdempsky/wd/go-fresh
Installed commands in /usr/local/google/home/mdempsky/wd/go-fresh/bin

real	2m38.429s
user	8m44.041s
sys	1m12.032s


$ time sh -c "( export GOROOT_BOOTSTRAP=$HOME/wd/go1.4 && ./make.bash && GOARCH=386 go install std )"
Building Go cmd/dist using /usr/local/google/home/mdempsky/wd/go1.4. (go1.4.3 linux/amd64)
Building Go toolchain1 using /usr/local/google/home/mdempsky/wd/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for linux/amd64.
---
Installed Go for linux/amd64 in /usr/local/google/home/mdempsky/wd/go-fresh
Installed commands in /usr/local/google/home/mdempsky/wd/go-fresh/bin

real	1m17.707s
user	4m18.335s
sys	0m35.912s

@mdempsky
Copy link
Member

mdempsky commented Jul 15, 2021

I just checked, and

./make.bash
GOOS=windows ../bin/go install std cmd
GOOS=darwin ../bin/go install std cmd

and

./make.bash
GOOS=windows ./make.bash --no-clean
GOOS=darwin ./make.bash --no-clean

install the same list of file names in $GOROOT/bin and $GOROOT/pkg, and they mostly have identical file contents. (Out of 1237 files within those 2 directories, only 71 have different contents.)

It seems like a bug that they're not generating identical files, but I'm assuming the differences are just build IDs or file paths or something.

Either way, I think just using go install std cmd to install cross-build toolchain packages and binaries appears to be preferable to make.bash --no-clean, so I'm further inclined to say we should just drop --no-clean support.

sha256sum diff
--- /tmp/old-sums.txt	2021-07-15 14:37:24.209280043 -0700
+++ /tmp/new-sums.txt	2021-07-15 14:34:38.263065640 -0700
@@ -1,8 +1,8 @@
-c420b01ca1af0461e1b6de7a41793307ba33af6623098f4a534aaf995d76f819  bin/darwin_amd64/go
+77d6e38eda5b57ebe693ccd79f24c931f03ffdcf11b108de1f0aafac788949c7  bin/darwin_amd64/go
 b4d28f55a4bf3ccfbd7e08b415855b212206ae35c28cfefea310fb8c45902ae7  bin/darwin_amd64/gofmt
 c7c0634ae43369f97de8e77b724e85f322951dcd765c9c17f349dab6ac5c2450  bin/go
 8874ee4fda255239d8544f5125d8f8f8777f6b36d688e300686c1eb1c697f081  bin/gofmt
-8c8fb2e92f4bf0a6dbcf6e1f897ebc0b6e72769078bc8e9b7bc68cae4cd8f0c6  bin/windows_amd64/go.exe
+806078fd7dd880e38116aac1aabcaef6a5860c59dcc851cd33588ae54666239e  bin/windows_amd64/go.exe
 012ae7cd8079944417879858eaad7f51542f477876448cee269c7ab330b71083  bin/windows_amd64/gofmt.exe
 5151927050c45531c499df6a2026fcb00e8b92746e70679487c72bd8ce04ebda  pkg/darwin_amd64/archive/tar.a
 b6ed6cbe858b7e3f82938230fd6039b8024983fe09c465bcf914bc390ddd6aff  pkg/darwin_amd64/archive/zip.a
@@ -28,9 +28,9 @@
 3817a7ead490cbb05e4f0885d66883f780722db15e99552e7c79f918f343e2eb  pkg/darwin_amd64/cmd/compile/internal/types.a
 4647870d098bd9e539331e98b648f409ba356c1a6408b4f03b011074ce7d3aca  pkg/darwin_amd64/cmd/compile/internal/wasm.a
 4fdc59469521bf02c3b9c2330eab6ca9541e3daf78945aecf60e352396da788b  pkg/darwin_amd64/cmd/compile/internal/x86.a
-cb7a21e845cff01f361db0317ada500b7b88643642de5c0606e996d9b61f3acf  pkg/darwin_amd64/cmd/go/internal/auth.a
+882891d951611ef998ef175c0dd5a908b81a1934ba66fbfa9f31ad64babb52be  pkg/darwin_amd64/cmd/go/internal/auth.a
 4e27e165417c2ae60855a4ba75406abad38f5daa19ac83ffc818c1208e48a1b4  pkg/darwin_amd64/cmd/go/internal/base.a
-9e8793fe05a5e1a1abb01ae76c5d27f41368b02b8f2619827aa09e025750cf3a  pkg/darwin_amd64/cmd/go/internal/bug.a
+f472b730e25c29a4fd0c730d42b1c4788a3c892d06bc3eab9e25849bade44d6c  pkg/darwin_amd64/cmd/go/internal/bug.a
 c8f93e6c88680c8525aa3369260aef07e316cb2373edae0d1528fca98737eea0  pkg/darwin_amd64/cmd/go/internal/cache.a
 e2aab7a78771995af0a3217a6de6c82fd0eaac6a51239e1287cac9dbf666a4f9  pkg/darwin_amd64/cmd/go/internal/cfg.a
 f03ffd642095085055f02a430f9170c05aec8594a62e8d574b006d535addb59e  pkg/darwin_amd64/cmd/go/internal/clean.a
@@ -41,7 +41,7 @@
 cee99a07ab5eb0b2c7dff3794fad1acb57debc7dc3a7d4862e60e17833e5b1cc  pkg/darwin_amd64/cmd/go/internal/fmtcmd.a
 b1e51094156bb6cee698bf184f3fad7dce6d32f3062ce80f297fad9f143ca5c0  pkg/darwin_amd64/cmd/go/internal/fsys.a
 44cab2735f27e1cd5f96a677ccfee1d195a81a6b258185989c6dce178144c238  pkg/darwin_amd64/cmd/go/internal/generate.a
-5fd8c2c293c831eb2f19db8dd8eec22f2ad8ec69544a716a739897ee63352e17  pkg/darwin_amd64/cmd/go/internal/get.a
+4bb73a515b594e2c29a7be236e7213d97fdfddc89c7bab29ac20551bf678e7d3  pkg/darwin_amd64/cmd/go/internal/get.a
 1b19f138c71ccdaca5763ccceb076a12eb4b06862347bc166ec76438373b1e64  pkg/darwin_amd64/cmd/go/internal/help.a
 549a16d32c2961ed74ccffbcd45a412dbcd1bb54f08082bf1c346de21739d6df  pkg/darwin_amd64/cmd/go/internal/imports.a
 e0b4285ec1f53754b5b76e8cd3eb7777791f57656d1ee1ab9238cd499f7b45f9  pkg/darwin_amd64/cmd/go/internal/list.a
@@ -50,8 +50,8 @@
 01eb12784e0147e35e5f977c2d5d88de0a8f707498067f99d70743d6c633a7d3  pkg/darwin_amd64/cmd/go/internal/lockedfile/internal/filelock.a
 0bc8960c17e0f5367a138bbc200cfc20ddf0972b5c779f3de9451cc0ad1bd3e5  pkg/darwin_amd64/cmd/go/internal/modcmd.a
 06ce981952cb9c2c24281de1f27e454e0e8fc047d51389e9ca975f5f0ae3acac  pkg/darwin_amd64/cmd/go/internal/modconv.a
-d624b7f7418b54b6b84f095734d27abcb338ca1b54e5cee4917f03748a79c303  pkg/darwin_amd64/cmd/go/internal/modfetch.a
-fd047809191e66cc34dac83047260915d5f72d44fe9f7e2d4e96800b7e805577  pkg/darwin_amd64/cmd/go/internal/modfetch/codehost.a
+9fddfa0fe52d82a692298dc91de6a2eb2f07eb0eee451cc69a0a3c99553b8219  pkg/darwin_amd64/cmd/go/internal/modfetch.a
+59218f6e7dd88bc1283745ae11b4c9aedb2275f7ba82f34c5c38ce2fd67d541d  pkg/darwin_amd64/cmd/go/internal/modfetch/codehost.a
 4d0799f5881e5af69de885304e99fe5de1d43aafa4b188508bfe5caf141686c1  pkg/darwin_amd64/cmd/go/internal/modget.a
 9da58e176d9bcbeb76af453268f94bcefa9fcd464d2a0ae805f8c307e65d45ef  pkg/darwin_amd64/cmd/go/internal/modinfo.a
 b92c7e133aeb34003566fbba55e2df87995a684ee6d8bb4b1cd9599d78eab04a  pkg/darwin_amd64/cmd/go/internal/modload.a
@@ -66,10 +66,10 @@
 b8e45b4c17a5fb0ba3b8d9140e092bec22dbc8add557cb0e5acfcfd7fd689eb0  pkg/darwin_amd64/cmd/go/internal/tool.a
 bc3d63a1dcb9067adf2418ef30ef23e669425bdd6edf42f8df2f9be2f0ed73b5  pkg/darwin_amd64/cmd/go/internal/trace.a
 a560ca580381dfed6c8ea9ff10085a674a4a6a1992229da0c3d09f5f2c89cfd8  pkg/darwin_amd64/cmd/go/internal/txtar.a
-32b933d4ac1db67b58fbea66616f5c05f24c0dd84c1407744f7aa89ba67dd33c  pkg/darwin_amd64/cmd/go/internal/vcs.a
+dae8b85dd1ff62eee80e80d26bad728f009d8d6fbb2413c72e5cb26c92c7a49a  pkg/darwin_amd64/cmd/go/internal/vcs.a
 5942ca1c1e2686fc99455275dcece952d414c1f9eb4fd1003f28d64cd337840b  pkg/darwin_amd64/cmd/go/internal/version.a
 1d9400ba6bd4442d32c80ab499406a5d1938282dc8a097a5615cac23747f3797  pkg/darwin_amd64/cmd/go/internal/vet.a
-ed06405e4ef0502f9b5aed64430ed15402d3cf7728185aa7df6c9bd864968ab2  pkg/darwin_amd64/cmd/go/internal/web.a
+d742d2496026b63eb9a5885089647a3a641e8dd72d8a94f4ea4e255d52ab77d9  pkg/darwin_amd64/cmd/go/internal/web.a
 f2bd7f0b6e9158cfa0dc6f4341da35105eea06d1f9c78120708393c6a01e7f09  pkg/darwin_amd64/cmd/go/internal/work.a
 723988e1670caa9cebd9d20ab36992cbf9c1d44f3b8dd07eefee7cd7ce1c8b98  pkg/darwin_amd64/cmd/internal/archive.a
 1489d55a904dc151ceaaa31f1f8a6b1a88ee40671775b3433327eed11d63d71b  pkg/darwin_amd64/cmd/internal/bio.a
@@ -115,17 +115,17 @@
 4eea2b661c68d3df44af689026c92325278dd033ede29258517d9ae769928479  pkg/darwin_amd64/cmd/link/internal/sym.a
 29c1a998890c6d6d8b92f0eb652f473826453cae0162facbddc789ee385af08b  pkg/darwin_amd64/cmd/link/internal/wasm.a
 efdc6c0344769dfb1854ceef3dd97542d0ca10277f50b975f723a1d28849a714  pkg/darwin_amd64/cmd/link/internal/x86.a
-37d1aac027655a0401aea25d937bd88e6e38bd0617000aef12d22eada95a5e32  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/driver.a
+197215eda6cc4fdf0ff4aec2a0fd6e0b740484dced26fb335272f99620f3a997  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/driver.a
 24e6ff800ce2a7709eb011482de86245943519ff6bb1faa35a90ef8afa016a44  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/binutils.a
-97976a899f415e8f65cd0f72c1dba91384c39c45b018296fd75073f3579ed5c0  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/driver.a
+6562698687db18010a1dfb511f6744cd284976abe5999ff0b488971adc0338fc  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/driver.a
 e5d68cd01ebc69a2bb41f0d70fe366766846b81803b1b4080c8961a5c406936f  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/elfexec.a
 82dcbe153821c511bbbe0175de4ec355829b16ef9c530b49077c5832658b06c5  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/graph.a
 8375863cd2cfa12aacd0bc43cd7bc04a47349d6f874dc9279f69a9a028021d47  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/measurement.a
-722aeb630ab0a529dc13d4b481a829e984a5db7098ce6054963acc13f975582e  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/plugin.a
+40d343b76c9f4b225b4ecac0f0269b57e250a2df6c81b945d6e60a3cdc1b8131  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/plugin.a
 1c3f9cd820d015d6808e1d28b9d0e23b49f4b2cd97d3dbc482e9e566cea14f6c  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/report.a
-83da6b36a05d8010c936836d227cf393625f9e697e1a21c1b6ad9e9a16fb17b7  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/symbolizer.a
+9a4de564f0339b9870ff7aa1a9594e05e9e3c517a138dc4d928f31e8cf31aa50  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/symbolizer.a
 b4e199a50d018455be86a8a5818aa0dfc90df02dfc557498ab50cbd4346ef468  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/symbolz.a
-719ead01c3b5e9a2b2992db26594d9b24696de0f3b8750553f8c781bd6b5c662  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/transport.a
+c005478d5d20ec79a3b3204055b9d92c10e4802a3cb77ecb01d4b162fdf06629  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/internal/transport.a
 956ebb4d04eaf77b3203bdf4271405425df064124631bb6d268306b12b7abc04  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/profile.a
 fc320933834b617993d15eeafddc5f2b7be63f2cf247379a25336b0cb98e2b3a  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/third_party/d3.a
 814eb99e8b6e2cdef53f6c5ea93da1b1d0f0e272d645aff855231c158494b727  pkg/darwin_amd64/cmd/vendor/github.com/google/pprof/third_party/d3flamegraph.a
@@ -142,7 +142,7 @@
 84352bfbb7da76e8c79bc5501be3145da7975ba7924f0177978a12bcb1d3a0f5  pkg/darwin_amd64/cmd/vendor/golang.org/x/mod/modfile.a
 651a34dd29b6893996656dce5a971099c22d87b299db548ba74f24bdee16b159  pkg/darwin_amd64/cmd/vendor/golang.org/x/mod/module.a
 ad05ec32e813e01064c6fd90802337ad081ff0cf32ce4d00a4d40367e442c570  pkg/darwin_amd64/cmd/vendor/golang.org/x/mod/semver.a
-cbc80b3f680be7d077671db10607d32f4d123cb206365e57ea3a905cc8f8e99c  pkg/darwin_amd64/cmd/vendor/golang.org/x/mod/sumdb.a
+c28c5d8b80c6ecfb4c59464d7bb7d9b9179153a69b00a230df93699da8258711  pkg/darwin_amd64/cmd/vendor/golang.org/x/mod/sumdb.a
 edb5dc03fe6c8fa9c06b6ea168b34c0c40e739cd5c5e872fae53c044fdf604f2  pkg/darwin_amd64/cmd/vendor/golang.org/x/mod/sumdb/dirhash.a
 05185756ea15acd45a699afc1b024339360aac42bb43dca09735cea6e608032a  pkg/darwin_amd64/cmd/vendor/golang.org/x/mod/sumdb/note.a
 0aecdb8666066a54f503cf78a53e560ed21d4555a0fd17894f3d0e337609d048  pkg/darwin_amd64/cmd/vendor/golang.org/x/mod/sumdb/tlog.a
@@ -205,7 +205,7 @@
 92f5c92eb1b306ee0b20bb992d015f0086045602c614c65ee67b47ad0d7f1fa9  pkg/darwin_amd64/crypto/cipher.a
 143412e6c0a4fd2add5c1996d96ca3f2a885d189be8c2180ebfbe701e7dfff4d  pkg/darwin_amd64/crypto/des.a
 db5897097959a66d1447ec12f75ae816bf58acfb71d7cc2fe212c5401271f696  pkg/darwin_amd64/crypto/dsa.a
-efee42e75cbde9869a5e1e096bc0dddd441a89425b55c605d4a33ed90359b998  pkg/darwin_amd64/crypto/ecdsa.a
+ace8397ff21b86dc99de1cc988c70b6d0c1312c707c5e4f715faec48aa90f6cc  pkg/darwin_amd64/crypto/ecdsa.a
 a2c7879553329e4a58d7af416561639cf927ccd2d0200877ea90dbc662ac9581  pkg/darwin_amd64/crypto/ed25519.a
 4f4fc198880f64b0833879afb2c6aa4b2a82d8ddb3c02f80cd8053eef0e96c97  pkg/darwin_amd64/crypto/ed25519/internal/edwards25519.a
 0dbbff5abffd9e478b0c336dfc1b15b86c61d3c9643703c0190e0e3335144062  pkg/darwin_amd64/crypto/elliptic.a
@@ -220,8 +220,8 @@
 9133753340e32b0d71ac6fba1d2ccdc1650d77e7a8ad933f4a607382fe044c08  pkg/darwin_amd64/crypto/sha256.a
 0b6912c259f8ba19efe95e7482c2556712030c13b8c1c9f8f3bf8a5d5268ed71  pkg/darwin_amd64/crypto/sha512.a
 9b36378cd2dcc43d15fc13d5677860938f966faf667ac1babeca8f83af6bedea  pkg/darwin_amd64/crypto/subtle.a
-28cbaea586edbb91b8ed2d2834f7dd2f748d61f5105dce28a9427f3996ca3523  pkg/darwin_amd64/crypto/tls.a
-a80a0d56dc25e9391c73bbd49dc3f0cc36317ecc250b1c1c00c897c0aee1cae7  pkg/darwin_amd64/crypto/x509.a
+414a7dc666d8cfffd625a585efe8288bb5b1e49bc12fdb57a72cd2f6e1f28ad0  pkg/darwin_amd64/crypto/tls.a
+3bc2372cf5a698bed55b8d369c3724192123e04118f94f2e79bc3d877fef75c3  pkg/darwin_amd64/crypto/x509.a
 a00eac25e70124d2f60b1201f4432e1cbc6ff7a9ec77c0ad8cf7af04aaf8786e  pkg/darwin_amd64/crypto/x509/internal/macos.a
 17369895222e93d8e635c3ef619cd212c9e83378dcbef5dfebdf6b38fb34a41b  pkg/darwin_amd64/crypto/x509/pkix.a
 100578eae5e8811968cb513c3ff641758459db1f8af59443c38e32de508caeae  pkg/darwin_amd64/database/sql.a
@@ -246,7 +246,7 @@
 15bff41e6abd2c697e800ce1251c8da95684c9afa266663506895cf6c9a244ff  pkg/darwin_amd64/encoding/pem.a
 a2672ff529a3af6f023a79c0f632959176b29dd3acdd10bcecf79ae563c157e5  pkg/darwin_amd64/encoding/xml.a
 78fa907064615ddd446a216a194552738c1129ef2905ee7e16d3c68674647a87  pkg/darwin_amd64/errors.a
-c06138875d2d3ee7c0fdfc66df5a22ad47183312b52d22147d57e8c7671c4762  pkg/darwin_amd64/expvar.a
+e2282e523787746f48733bc8a45b47cb401cac184d048bccdafd88ac5dccfb44  pkg/darwin_amd64/expvar.a
 2805706ecc8d718c122ae416bfbd1016c55a9d7928980de990b808ef7c5ded01  pkg/darwin_amd64/flag.a
 eed67cccbeb1d021c3c107e643dfc627a9e48f1bcc6cd15afe063e5e756f4bc4  pkg/darwin_amd64/fmt.a
 8139070802cb0377d2d18511d8835c7e0acdad0cc4fa72c6b10086f62ae854cb  pkg/darwin_amd64/go/ast.a
@@ -310,31 +310,31 @@
 bfb7282be3be43784bc4d92ee0f734e3ebf1f6b491b0061380e45afdc2344abf  pkg/darwin_amd64/io/fs.a
 2f7c27b3a3e17efc7577baa81e17bb1b176fbbd77216483a9978558b42b0681d  pkg/darwin_amd64/io/ioutil.a
 f76da42519a4c99db66a18edcb2bd23b77f0810465651f68099f8617d4d605f9  pkg/darwin_amd64/log.a
-375ebf427d0f25c8e4246618e94c4498042693ef270d5b3eaad2dffcdf5b3f5c  pkg/darwin_amd64/log/syslog.a
+32b81df48afd31d9100f494b93df9b8220312b535186ca1fee6fd07386fe566d  pkg/darwin_amd64/log/syslog.a
 24584a9dfc5620ee4e38698ff04bdd47c4ab0b6b2565c4490bc5087556e80de2  pkg/darwin_amd64/math.a
 590e2dd8b90d45d2b522c90f7abeb7d8cc73ea81f19b134465f4776084008768  pkg/darwin_amd64/math/big.a
 993fa687e3e6c2dd3a1c83019c689b693c9b226bdb5d4a5ac502f73fe5037579  pkg/darwin_amd64/math/bits.a
 76f95f9f9970b226f9cd4324900013335e2b98fc99b0f251f34f6f445c5a20b0  pkg/darwin_amd64/math/cmplx.a
 7829e1b6f29a9a7c772fa7a7729fc80dd9071c5b5e5028f7e9e8a7dff545b104  pkg/darwin_amd64/math/rand.a
 ac3cca73d83c11437597369b870a6a7b9dc42e8abe67078051de554e6a804d5f  pkg/darwin_amd64/mime.a
-7755a2555611c90904c85fcecc229b943e48bf102a22fe64286269e3f61e1d95  pkg/darwin_amd64/mime/multipart.a
+3187e94c3cbde18fa3106d54b505234bec0e9e79ec9b398d9355089eedf71eb1  pkg/darwin_amd64/mime/multipart.a
 59e687e343dd237e24aa2e5a735a3bdd257df72d5c8e6fa524b15c51a0993c79  pkg/darwin_amd64/mime/quotedprintable.a
-1430122b95356daf1f5b24631faaab221581c970c7d04ffc1759fe5509d9ebdc  pkg/darwin_amd64/net.a
-6d77b87e2c63b00fa5f25002be9cbf0b841b9d5240682858bc447896b2b900e5  pkg/darwin_amd64/net/http.a
-ef61a5be4f4869aeaea7279299ec97fb9a483dd1b1f72a20fbd3fac1ec1cce83  pkg/darwin_amd64/net/http/cgi.a
-16d2a93218609ed67ebad4f596bbb728ed9a4ab4ff0d2516916f121ccde38f13  pkg/darwin_amd64/net/http/cookiejar.a
-3af37bd76e18159cb31ab8265c683f305721807baca7fa7d15f4f974c128b83c  pkg/darwin_amd64/net/http/fcgi.a
-0fe3f24ff22c6518d8adc0d8efa804f8e962fdb48baa11a8c5a91e6a20b78738  pkg/darwin_amd64/net/http/httptest.a
-4f885e0a979ea0d7d6418a4059cc53990f7a81a79f24c1076ae7eab8da88177a  pkg/darwin_amd64/net/http/httptrace.a
-d5e8a9dfcb7e87b5c8b716e4a20de77e9966bf2eb3d74074881a3dd488f04943  pkg/darwin_amd64/net/http/httputil.a
+f594cad1c1ae667ea2444de5065ebe51bbc67c18ca2d66b0a2d69b1e5c94e934  pkg/darwin_amd64/net.a
+a2cfeda16de799598f8974a31c8b44f582a8c8ee20f0c85b03b2f6df1ad1321c  pkg/darwin_amd64/net/http.a
+a965e19c2df22f688d9e76445324ff49fefabe34d75e94e73bac7ef2b5c85aa6  pkg/darwin_amd64/net/http/cgi.a
+e114a9a26949addd9f8d7596fa3d3e831e32931cf5a1262a08bf73a49a0747c2  pkg/darwin_amd64/net/http/cookiejar.a
+57394dab548c10a356db1ab553320ce9e59875f82875e0bdee1745c811ecf40e  pkg/darwin_amd64/net/http/fcgi.a
+f126cd2b291249b4c5e77b5ce2f44cc1515b728ff3498d4f865247eaae2578dc  pkg/darwin_amd64/net/http/httptest.a
+c05a5217c9b395c811fbfd92206caea7d3686d47d7d2934adf62166e353a4604  pkg/darwin_amd64/net/http/httptrace.a
+88eac0e089ccc3c2967e0296da8c74c43b735d2ed83a69232bc081713a85e2a2  pkg/darwin_amd64/net/http/httputil.a
 13a7e5197dee043871996d71487f68f0655d598a45a8eb6df3805bb12d86a588  pkg/darwin_amd64/net/http/internal.a
-0425a07a3e21b1bba1b02e756256b1025bce504e8f17ed21ab3efad234ac5866  pkg/darwin_amd64/net/http/pprof.a
+f2fbaa8059dcc9d80c4359673ead4c2a4309b2b62fd81638203fe1811b0b5120  pkg/darwin_amd64/net/http/pprof.a
 b77fec4740921b563954b41223af7677875dfc2abe17dd018af2a0e60d053de6  pkg/darwin_amd64/net/internal/socktest.a
-4e7a510a94da55309382390aac7da9e8ffc370f16c239d9b99ced002c0abec72  pkg/darwin_amd64/net/mail.a
-0872212c2b52308fbb127d135a4bc3151cdb4ab203e3fa99b08f0dd283b18e25  pkg/darwin_amd64/net/rpc.a
-fb32e144a0e8ce2e2bfd5cb2af2636bb4c3f4845779b1389707ef77cd47122b5  pkg/darwin_amd64/net/rpc/jsonrpc.a
-e127270bf9e6c86da8f9974fb6791a6d0bdfcaf832e2169346f220fe4e48c11a  pkg/darwin_amd64/net/smtp.a
-62af467397b483fcc7de4f1dc06764fdae2cd77d1f6565c524b08c33271a7dcf  pkg/darwin_amd64/net/textproto.a
+d8cf7af03eace150fcc3d386f256b65aea06608f7a67a62f2003a577588f96c8  pkg/darwin_amd64/net/mail.a
+3a5227b95b87f73745918d0303295bc64a88033830bb578fd230fc5aed9e0c8d  pkg/darwin_amd64/net/rpc.a
+60403d2310d80f7a807b4b866e1062b6a30b96bddc4eb222cbcfb9244d41a960  pkg/darwin_amd64/net/rpc/jsonrpc.a
+83ba66a485b50bc518e78d628e2f4fe4c427e21efe5b744aa7b4c8681f7f15dd  pkg/darwin_amd64/net/smtp.a
+8923e3cdb074c537cee316c46e8de32227d31fc07937f7914324412d3062c27d  pkg/darwin_amd64/net/textproto.a
 f22b915190992d03737073a33f4244fdb024da54e7e950b992c469bf348ebfd6  pkg/darwin_amd64/net/url.a
 4e26c4f3343d41b34389136d3636b8c98349c9b4b1d520ab6836e075857a85f6  pkg/darwin_amd64/os.a
 c7361dc2223cac0a7760d39550e5228aa3f48d3697a0149c394c4ea630bbc34b  pkg/darwin_amd64/os/exec.a
@@ -385,10 +385,10 @@
 f48c2b89d95c2fbd1d467184dc136e63e675627fd1b232aa2a72a56be5cca10d  pkg/darwin_amd64/vendor/golang.org/x/crypto/poly1305.a
 7cb994f06e8b2890293969291fc2773df38aa40df388f2437c7ba0531912d668  pkg/darwin_amd64/vendor/golang.org/x/net/dns/dnsmessage.a
 dfa4a7c00301f23ff53347dc433fd4a19bbe5c32b654305d56b32104a4af1671  pkg/darwin_amd64/vendor/golang.org/x/net/http2/hpack.a
-23c62d567da4c372b3c7899aa611bf37c296b0f642d3b13cc8be15c809f96501  pkg/darwin_amd64/vendor/golang.org/x/net/http/httpguts.a
-2ef45980f5d9dd8da0bdadf68c36038187172a46f104921d0785d23d3a52d238  pkg/darwin_amd64/vendor/golang.org/x/net/http/httpproxy.a
+bf02b664e47aff202c2cea5264879729301ac028e1952068e700b3d6afcc500b  pkg/darwin_amd64/vendor/golang.org/x/net/http/httpguts.a
+7bfb28bb4fd2dacd6f030fb9bbb917ee59b01039462a05d3f5147bc0523ccddc  pkg/darwin_amd64/vendor/golang.org/x/net/http/httpproxy.a
 73c44db1cda4ed4b46fe68da4891a263704f002276db4d2f9ec6bfd9f80d935e  pkg/darwin_amd64/vendor/golang.org/x/net/idna.a
-4d85dbbc563c79518f2bc8f6b0c51e6a3bd351fad76d27df8f7bb3608c280f4b  pkg/darwin_amd64/vendor/golang.org/x/net/nettest.a
+bbb8c92e9f1da8326aa20afa3038650db1da403ee4e845e94a35110daa600d2d  pkg/darwin_amd64/vendor/golang.org/x/net/nettest.a
 6cd36cd06a2eb5d036ace7679473c8823bca60c9e2f7924539f546f8d48869cd  pkg/darwin_amd64/vendor/golang.org/x/net/route.a
 c5764f9feda456a2e0fecf92898554b533ea1954386ad340da44cef64ff866ce  pkg/darwin_amd64/vendor/golang.org/x/sys/cpu.a
 7b21b0e1bf5b3a46eeece134c9a5b1989ee3be599d024a42c9a1d28ce0d86f9a  pkg/darwin_amd64/vendor/golang.org/x/text/secure/bidirule.a
@@ -803,9 +803,9 @@
 a3ebf0bcaf3ec96499496def575b1df3bdea7373f73de6b0c649f8a7609a0e19  pkg/tool/darwin_amd64/nm
 f6711b741d26e8c8a814586beb3db07b7a855bed6c74dfc8befd98d5e72222f6  pkg/tool/darwin_amd64/objdump
 3457ccebb2f77993d97123b11257dd99697d66c724e54983d995c0c79ebfd4f2  pkg/tool/darwin_amd64/pack
-f5e3766020c18b7670f80d498f3482d3d58b5eebad54524a204312c1f203831c  pkg/tool/darwin_amd64/pprof
+d9b9f947b3ef899e0cd3af0179fdfbab7e6df9005107c4cb5d7feccdccd94e31  pkg/tool/darwin_amd64/pprof
 83ed8d3c63573bf2fe0ed8ea07438b5d28e1602a5ffd03a63d1eecdf6ccc9956  pkg/tool/darwin_amd64/test2json
-839eabf588c8f9e1636f57d705fe1eedbf2ea938c50276109e17c1fb982053c9  pkg/tool/darwin_amd64/trace
+1c3ddd11279a4a7a73c813ecaff68d4b0dc679e212ec4f493b38062ef057a085  pkg/tool/darwin_amd64/trace
 2ce29ec634b10ade9e7f852a3c8b57bf242d29c005973fc4e76429854f8d16d6  pkg/tool/darwin_amd64/vet
 aa4cb886527380cf12bed42dc8842a87fc32532c8aad4022beb6b32d596907e3  pkg/tool/linux_amd64/addr2line
 f872f3ef7f3936c71cc8a977b3dab4a1ef63b17620a32717572525ebe0339236  pkg/tool/linux_amd64/api
@@ -839,9 +839,9 @@
 d35829639691f7f63a8bde82503005269f13d55b384092db6d4102ebd69c436b  pkg/tool/windows_amd64/nm.exe
 e85cf4b888fcb31024dc49cc3dcb9f031344cc5c964c52b22df33c81166967e8  pkg/tool/windows_amd64/objdump.exe
 5f710ebaeb9b9ffe9a71709df6f857ffc246cec2f97b242c02029bfc9db49ae2  pkg/tool/windows_amd64/pack.exe
-ccd4bf5e8f2581107b145b49e28f231c0999edadca499076d6f47d964005171a  pkg/tool/windows_amd64/pprof.exe
+143ee5edd279fdb4bbe3897d206447ff4a0aa400d5f6aed9fd18a368bb3f4ad3  pkg/tool/windows_amd64/pprof.exe
 36b5d85a9705242b5bed0cf04755c1cd08eeebad8835854aafe6ff60f81e2291  pkg/tool/windows_amd64/test2json.exe
-d4ad1f157b292368b876ccbc04f2d7b11eb8e839bd6e7f699d96233863301e7a  pkg/tool/windows_amd64/trace.exe
+4d808d124923a4213fa85f68b5aff1f78c661f7f12fb532a5608f9ad3ddc7904  pkg/tool/windows_amd64/trace.exe
 44943015996bf118efe4148eb7b8a257a053eea9e0bd54d69a0a9769b9aee6b0  pkg/tool/windows_amd64/vet.exe
 1cc59cba21530ad59e9a9251bbd3adc1576068cbe5a059233c75fe5275b2dde5  pkg/windows_amd64/archive/tar.a
 a57ea6460ba8ea5c0420be626abd89d5466418c5ac7fcf23a25b73f82399d339  pkg/windows_amd64/archive/zip.a
@@ -867,7 +867,7 @@
 88d98df681e024fc6535ad98b448edad7e30719fad5c9a8fcfbc64d568b8014c  pkg/windows_amd64/cmd/compile/internal/types.a
 6c4d406f7374f10a95dfbccfe03f9ece0805ee7b00299259572a2e27e661d5a5  pkg/windows_amd64/cmd/compile/internal/wasm.a
 c8628cfff290f3b229dcc75fa24267fb1eb6a5244e00b809d3e96f814ccbaf2c  pkg/windows_amd64/cmd/compile/internal/x86.a
-d77c8c0b977b39fc4fc16342d07c6852a50ac285bc2ce5e108961eb710543775  pkg/windows_amd64/cmd/go/internal/auth.a
+c8122c69ecc6b7455c9ccb0fed343ae889b6ff044f372d42a5d867ecd236cf89  pkg/windows_amd64/cmd/go/internal/auth.a
 f1177fded018b0dd6315a67bc26d79065c6a91269db2cb5fcd29a9589f7049a2  pkg/windows_amd64/cmd/go/internal/base.a
 91eb82f39fb53b1994e527c406e39f0fd3aa3c6eae100d837d736c574691f942  pkg/windows_amd64/cmd/go/internal/bug.a
 e315f91b5a18e2111b2fea8997c895a025c9f9f41961df5b431fe9f8bc6d5512  pkg/windows_amd64/cmd/go/internal/cache.a
@@ -908,7 +908,7 @@
 ad2f2d782cf6e6632a905534331c4b3f5d89051f60b010cf5259336f1b410c8d  pkg/windows_amd64/cmd/go/internal/vcs.a
 8e8d758267c99cc3fd1283f00ff99d4e06bb5f73276425c634f09d283a9f7b8d  pkg/windows_amd64/cmd/go/internal/version.a
 a5985647c2ccf722ea7084ebe5e5406534aba2cd1e1281f0f7b8cf69d0996925  pkg/windows_amd64/cmd/go/internal/vet.a
-d12d9ca8f06e554a8908adfee6676e74c3b7b94ef8ad119c02bd6f894555bdb6  pkg/windows_amd64/cmd/go/internal/web.a
+70cc7fdde2c2e2c2ba3495361ca4721a5d3fa8f401d880293533bf488b9d7dfe  pkg/windows_amd64/cmd/go/internal/web.a
 fb743fbd5ede14de0139bbe4449f97a1e510bb3536ba11160ae1551d5acceaa4  pkg/windows_amd64/cmd/go/internal/work.a
 372a0e9767e88449e6e68ca90b07f35cdfe7c33203a0d8f0d21e88b1860fd239  pkg/windows_amd64/cmd/internal/archive.a
 3831b593c7bcb090886f657eb347dd67ff5fa75ba85e8bd4cbcbc4927c1b358b  pkg/windows_amd64/cmd/internal/bio.a
@@ -954,17 +954,17 @@
 880f92ff91b0d5b5a1e9fad021358e0eb576ca8790ce3b5aa658c252da7eff05  pkg/windows_amd64/cmd/link/internal/sym.a
 351d5427831bf30bcead99bf31df752abfe6c9cfe4576d5f77174329672132f8  pkg/windows_amd64/cmd/link/internal/wasm.a
 38f29604af83343303f31dee975d345b6b521276d2b049646ca6ef9ae04f8c4b  pkg/windows_amd64/cmd/link/internal/x86.a
-f5e86e5631ac20afb8ca9f66d4bc405eadae4d3e2fe39338b68da19193e56fbd  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/driver.a
+2cd13af63b940f903d2f2c4a82c67a7efe0d7b02f843ab40344c24d25663c322  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/driver.a
 01d6eccd4ae93989438a35f6e400d3faf99e10f9c4c592387f4eef00ac11a565  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/binutils.a
-e8292fd06b14495a7f96c191d46d410739302f82d156a9b1b23abf712c02b00b  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/driver.a
+a479ff6d5088670d1c8fde4a538e230054be8d1c73b14c587a2f4c7c86e70fe8  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/driver.a
 1e57c9a813f8e67de67e4b6c6fb5052c9ed70487d15a18c527b47168325829fc  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/elfexec.a
 09fb530d83c021c24aa98cb447f7624ab568cb3887d9990f08e8871f40161671  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/graph.a
 bdd33afe4df7385c32f263756c19f4eb7448c7eb320b175eb78377d635aa4ad0  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/measurement.a
-88984abac8505a4756d58e694a263e06953dd5aa67fcbe20ad4ab8c0936666c5  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/plugin.a
+6379d6d001b005184686aa080974826b4959ae1ffa077aef44bc0ed278762acf  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/plugin.a
 47c4479044b1ad8002161444551cbfd44d92f649baa679e4c51f0dc038a0e9a2  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/report.a
-1603d7d0413b42a1f8f7bad841bb003c4457307852520e98cefe7502a198d1b2  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/symbolizer.a
+124486289c15b629c7dc0683fb62acbbc6fb1cecd15518f44b55c3cd74299a04  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/symbolizer.a
 a6a85d9fa9986c4b2f9e54d122b0e8c588d99add4840abcd9166b6fdc5939e02  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/symbolz.a
-f710632b728bb57fc05a9fe13ac272508f36ae57da8bf570b4e57e3b03371be8  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/transport.a
+5ccc2e78e6af1ed3e018bb522b9e562c4e632af85697f1edaae27972f414574c  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/internal/transport.a
 a941e554e1d4a71081ff8591fbf55ded314b4e20205473ffc5125a698a31a1e3  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/profile.a
 a097ff4adce749f0a42191fc3f94968f82a39f9a4968e5c18d7973bad3bfcbe8  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/third_party/d3.a
 03f7cba9feff66b0cffe519c68a15edbef0a29ced4ae50647a8f376006be34aa  pkg/windows_amd64/cmd/vendor/github.com/google/pprof/third_party/d3flamegraph.a
@@ -981,14 +981,14 @@
 16cfda97b3f4101e12c160fa06e8e5d8df3c844d68d24d70d374208e3915d6f4  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/modfile.a
 c7ac3bcf739b9bf7e3fc6bb74125bcbbaf3d2f2f735d8ca07ea44ead1fd42fbb  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/module.a
 97ad7548f7d3e848405c19f893032c5deb607430875dcdffae8d13c9b33d3991  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/semver.a
-fe5620e87ded68c3de3eb60d315064f190fbfc791f6dcf6e58f4efe8998f54ef  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/sumdb.a
+2e168996001389c45decbc5103d38b3d558c73349999c6eea6b877389cec5e38  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/sumdb.a
 0c5e0a899487f6be4e7ad874e2fed66dbae5b1ee1c18fd4b9c84e425810f0243  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/sumdb/dirhash.a
 8be99d26e72585028f292f56578146cbd739ccd45b4600a6c9ea9252d38228df  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/sumdb/note.a
 8d7c9c67853189cd128bbcce6b7d9424e731c45ddaa0c04b5968579d863a16f4  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/sumdb/tlog.a
 18bd81dead4080f55362d54e57db44d68374032ee1e094cc12ebd4574d5e80d6  pkg/windows_amd64/cmd/vendor/golang.org/x/mod/zip.a
 c6eb71f8a5601dd56b92d4a4c1d0395773a828e5a42b3786705287c2fdc7978e  pkg/windows_amd64/cmd/vendor/golang.org/x/sys/internal/unsafeheader.a
 915ae62e9d7a9ce489a55f517bd87c4243c28eaf4b8f0aa1226b39093362a122  pkg/windows_amd64/cmd/vendor/golang.org/x/sys/unix.a
-d9bebee6f3fb9b011ec59fa6ac21a378a2aeef8445fe4b2140627a1efcbebdb9  pkg/windows_amd64/cmd/vendor/golang.org/x/sys/windows.a
+692d39fbac70745ee4a45571144e7dfa554553b7444357c9f2ac6eabd3b5ca69  pkg/windows_amd64/cmd/vendor/golang.org/x/sys/windows.a
 819d6001913c9fb1a22aee3c4d544fa6a2f884620049349bafd793c01164bc00  pkg/windows_amd64/cmd/vendor/golang.org/x/tools/go/analysis.a
 6daced80c9bf87a87abab514e9c088a1e4a1e58ff19c5658dade8aac66a40680  pkg/windows_amd64/cmd/vendor/golang.org/x/tools/go/analysis/internal/analysisflags.a
 1e7b0c052515ebc034e21bafefd35381b22e2513d1d1a9a926ac898aa93e11b9  pkg/windows_amd64/cmd/vendor/golang.org/x/tools/go/analysis/internal/facts.a
@@ -1045,7 +1045,7 @@
 4bd8738ab916f45070bc32e2c25e0a50c24d2eba839bdedde2568f155930e41c  pkg/windows_amd64/crypto/cipher.a
 b43f7d97a47de98c0ebb0702886ce63dbe17f3c7ab20753f0db2de4642f3d777  pkg/windows_amd64/crypto/des.a
 debbe2560c0f881a2d6bc36f1696d8e8cfbe22e53a0877ac1e643814101a2988  pkg/windows_amd64/crypto/dsa.a
-a20810d5d23acc7e8b332b29d0f2697450e329f83151a8a6422121cc8843e108  pkg/windows_amd64/crypto/ecdsa.a
+6ee713ab44e419433f91b20d9ca145470d71220cfb9a8f93935a9c9853ef6f3c  pkg/windows_amd64/crypto/ecdsa.a
 0a2771a744c6cb56caf6192d8c1f943a246b8c8b1acc06b1b29a645f1cb8022a  pkg/windows_amd64/crypto/ed25519.a
 2d0b93af7c11150b5ce2887d98952a5160c4f7400647dc17da56f82ba15777e7  pkg/windows_amd64/crypto/ed25519/internal/edwards25519.a
 1c1b6f1a61449b29b5a1896fdbada77d4a0e6216292e9e96341c856e4e6957fb  pkg/windows_amd64/crypto/elliptic.a
@@ -1060,8 +1060,8 @@
 1b95dfc31b4fe4cb97af708f36f05eb825a1e48fb96007be623e6c21cfbbc2e8  pkg/windows_amd64/crypto/sha256.a
 790208e82aaabf93cf52de59d30c0a996643446a5243975af7924f207d28efaa  pkg/windows_amd64/crypto/sha512.a
 a95350872c25ac9d7dc073c7b3fa7f1f5845dc42cf28efa177d765261112f12c  pkg/windows_amd64/crypto/subtle.a
-a2807ad3d9728885b3e9de8226ba83aa00ba216bff7843d9397d372fe4133522  pkg/windows_amd64/crypto/tls.a
-b8b248da2a1107d8cc35fd8c2738e7791f1598a7d2f94bcb3395d5b7a1481490  pkg/windows_amd64/crypto/x509.a
+c8b5f7571c7d728f086b3079580876c91b57afc1b5229fc74479f4a111fbb65d  pkg/windows_amd64/crypto/tls.a
+3337755867af87bcaf9b06fbdcf406958f6c018289b3221569e9ef4a96d753a5  pkg/windows_amd64/crypto/x509.a
 3e3242d9566deee08239dc80d6c7b96793f81024b9f894b56f288ff1e1bd610e  pkg/windows_amd64/crypto/x509/pkix.a
 4064e2423de7260b556211bb95a757e5b953a8486476a15af940a5b133b946bf  pkg/windows_amd64/database/sql.a
 3823ffc02f5dcef56265690e7001f5bb6cea17c12a03eaea45dc43b920c337e9  pkg/windows_amd64/database/sql/driver.a
@@ -1085,7 +1085,7 @@
 feacce0e58fa5cc0b6bbb1d29b48fa48e9719d222d9973f296a005ca7fc5cdff  pkg/windows_amd64/encoding/pem.a
 b50c927726e72a3bcd816490daa064a9321e0d4fb970b345fa43b1797c818fc1  pkg/windows_amd64/encoding/xml.a
 dd216f4b350a874fd035915dd4271ff67579ec829216bb2a5684259baea6c903  pkg/windows_amd64/errors.a
-8e3d3d5b3e007957a41e2421c45acf055a654c78f2a55c4643e35cfc92e86e8c  pkg/windows_amd64/expvar.a
+90f12dc55ab23972783caeaba1a00b16bf2f9d2ba1b5f752aa7fa719b7b4a243  pkg/windows_amd64/expvar.a
 ff677d76e94bf6a0381b117cafb17f3d85b524cd46b658762473a812f34e7c8d  pkg/windows_amd64/flag.a
 7efe8842e89d64b5becbd4c54766d582c662981c6dafa6dd04edcc24ffcd937f  pkg/windows_amd64/fmt.a
 789bc8a0df64e24464bf49c9bf9d8587164aff834772689e221b86a47f93b3cb  pkg/windows_amd64/go/ast.a
@@ -1160,22 +1160,22 @@
 ec237168873c62d7e1330542df15c23af9602a70d0a7b2c2a20d85113cc3b6a5  pkg/windows_amd64/mime.a
 00f9b1cef1de40b1686fa66bdb08c1e61fc929c2eb7352c18721b63dfc288b85  pkg/windows_amd64/mime/multipart.a
 1112c9f09642b1f9b61a05a2dd625739fb581da272600d5e32000d84045067d2  pkg/windows_amd64/mime/quotedprintable.a
-2727ef215419118d335afbc3a2bd427c648622deb5b6bf20a31cf0223817f94d  pkg/windows_amd64/net.a
-0a9be338e0c20a49f61149fda4a2e7a6f6a1a2e89c3931d6fec8d76ee3d8ffa6  pkg/windows_amd64/net/http.a
-614683a30c0e3e93fa945d13885f39bb02fcdf46a2d34a41dc4b19ce09ef1a25  pkg/windows_amd64/net/http/cgi.a
-d9d12eb86931f6168f0d589b5877e2037e7074134b9017c0c017d2621b0e540c  pkg/windows_amd64/net/http/cookiejar.a
-a324386d130e59e4bfa3e49848c70e0055d8bd90580cb137fa66e11eaeec2e62  pkg/windows_amd64/net/http/fcgi.a
-3b73e0d49df1e8504efc7f98c59ce072fc70d09c5de9dd029c25f46b1a98b64a  pkg/windows_amd64/net/http/httptest.a
-9424fd7f1004ab3175f9e9d5abf61c0e4441a449dfa2b02d0e763f0d311b688e  pkg/windows_amd64/net/http/httptrace.a
-240ef830907cf20fe4abfbd7fbdd79638a7913cde1f3713648164a00536f95d2  pkg/windows_amd64/net/http/httputil.a
+c24d8721289a7879b6e52a6b737518a5d8abe801da27037edde73cf1ee1723af  pkg/windows_amd64/net.a
+fbaaf01ee3e602407c6fc054498c378d06900b48b114699bb87d2555e5f413a4  pkg/windows_amd64/net/http.a
+dbfb6461eae7ff1968082003240f10961810749411c4d04ef4cfe27fbdfe7fb9  pkg/windows_amd64/net/http/cgi.a
+15b0eec8edeb3c584ef968075eecff0b70274f9a80590a42f04e3043c45462c3  pkg/windows_amd64/net/http/cookiejar.a
+1052f17c3c03b0355950ac7f820a51351a239b89c310529ad8ba152ce9e22545  pkg/windows_amd64/net/http/fcgi.a
+ecee6038c43772aef3c00749ee54e7005f8d5fb2f15b64ecc02be6fc48008222  pkg/windows_amd64/net/http/httptest.a
+1f0811f171fcedd1698d22a5ac1d615b913a81043433ec2b993d81b43d04e41e  pkg/windows_amd64/net/http/httptrace.a
+7b4cc4a71312a43debc47ce48356614a43d8eba9a04eaea9817d6c80db4eeb5c  pkg/windows_amd64/net/http/httputil.a
 2671fa119fa2addec9a69e0bd673ce22a45a6b72c57b9cfaf678f3114236c022  pkg/windows_amd64/net/http/internal.a
-8af1b245a4b6a4c437f04075297d636d4a47a14fe012b17be683487a211ce7b7  pkg/windows_amd64/net/http/pprof.a
+f5b24dbf49fbb7dc6a64c21971d55c06e68b57ae985b339ab4d1751f0dbe3151  pkg/windows_amd64/net/http/pprof.a
 596feac11b325ec0be51636352464c884221f680b68593d1edc4a79ba5913446  pkg/windows_amd64/net/internal/socktest.a
 12cd57f541af981216c78a2a3426fc7b208df711c73034c611d02afd563ccf5e  pkg/windows_amd64/net/mail.a
-97895cab0e386a64908e3d0e14768a4cc56729a533f188481451457ba1383c2c  pkg/windows_amd64/net/rpc.a
-2a97b0cd370dc30765a6af9db755b135db2d960b7f1d6cd2d3c971fcd2e1004d  pkg/windows_amd64/net/rpc/jsonrpc.a
-487d7bf825b61b812621d7b8b266d4e5b82cf43fc33b5da4c27ceada3abef771  pkg/windows_amd64/net/smtp.a
-39d19ef9daa388fa5862738a2628d149191d1d30f880b89634e1329775bbd426  pkg/windows_amd64/net/textproto.a
+61f564164a4e6f95d84ac89f7f3afb589ce38da6b60dc11b6c22bcfbf477492b  pkg/windows_amd64/net/rpc.a
+705392a0ac354928a5085d66203925f9c0f3f32b2f52a48ceef7d0c2bee5562d  pkg/windows_amd64/net/rpc/jsonrpc.a
+d0adbb15bde01a3eb57fbd30606499466dbab571e2f0f62720edcc1adbb27178  pkg/windows_amd64/net/smtp.a
+38557f177c244a7f072aef6e32793d15ef85606b3dad46dfeb24f170e5ab70a8  pkg/windows_amd64/net/textproto.a
 bda5d199b98ff27cd311367b4cba008f245d4904a2d68f845f00c243cf8b6857  pkg/windows_amd64/net/url.a
 b805a8782b076a04c5caaf81513d13768d903f379d13b93dfca85dcbe0fca491  pkg/windows_amd64/os.a
 dd860a171be1181278d75dc05ffbda373568f9da08f03b8017f2f3a3cca91205  pkg/windows_amd64/os/exec.a
@@ -1226,10 +1226,10 @@
 d96681e105522690a146f052d4236175475c45dd02587e433f87170a479b7526  pkg/windows_amd64/vendor/golang.org/x/crypto/poly1305.a
 0159ebd19c64eae1f1d62feba86b13e58210184910054f849ba5876d3e140c82  pkg/windows_amd64/vendor/golang.org/x/net/dns/dnsmessage.a
 120050965e0b58b10a82a11169ab2d09045eb201591a71c836bab2b070c09c41  pkg/windows_amd64/vendor/golang.org/x/net/http2/hpack.a
-596a07236b68141ec94cdd58a596c965e3581504cdbc1238cbfe1488bb983fb1  pkg/windows_amd64/vendor/golang.org/x/net/http/httpguts.a
-be2dda360bc23f4f3cb37e7e9498bd7c072b233225c4f9738d1d03160017f0c1  pkg/windows_amd64/vendor/golang.org/x/net/http/httpproxy.a
+95ef7bceda33641444a4c6b80629397cca8d2fd0c6b81831618a142d867bc26c  pkg/windows_amd64/vendor/golang.org/x/net/http/httpguts.a
+0f16e2d50fe81ac693e1ba8e1bfdf6aecac8f7c5a333abaf90d8d51c2ea35bc9  pkg/windows_amd64/vendor/golang.org/x/net/http/httpproxy.a
 f764549de0ea02ed66f882722b8e06fa6fb90b2df6e8d34f7f91435f3ce4e19f  pkg/windows_amd64/vendor/golang.org/x/net/idna.a
-6a568839b2d7e075d66c31a646cacde9fabce2064543e9996f96eccf4065f9a7  pkg/windows_amd64/vendor/golang.org/x/net/nettest.a
+834cb8203badaa826d76b9229b88fabbb2f084ffa9f519b592d5e82607cb026a  pkg/windows_amd64/vendor/golang.org/x/net/nettest.a
 dfee0d7fd4161a178cd76e2461cdada62a9e8722d012253ad94ef03c1be66374  pkg/windows_amd64/vendor/golang.org/x/sys/cpu.a
 25d39a876479b3f44c6d62d8cbf3960b0363b49e32dfb0585161e77c9a986493  pkg/windows_amd64/vendor/golang.org/x/text/secure/bidirule.a
 32f505ec9ea6352f4b666e53781f83fe9eaa8454648126fd143b1243dd719147  pkg/windows_amd64/vendor/golang.org/x/text/transform.a

@mdempsky mdempsky added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 15, 2021
@mdempsky
Copy link
Member

mdempsky commented Aug 11, 2021

Does anyone else want to weigh in on what to do with make.bash --no-clean? It doesn't look to be documented anywhere; and as reported above, it seems to just generate the same file set as go install std cmd but takes longer (because of repeating the 3-phase toolchain bootstrap). I'm still inclined to just remove it.

/cc @rsc @ianlancetaylor

@gopherbot
Copy link

Change https://golang.org/cl/341392 mentions this issue: src/make.*: remove --no-clean flag

@ianlancetaylor
Copy link
Contributor

I don't care about the --no-clean option. It's fine with me if we remove it. Presumably we should just ignore it, and existing scripts ought to continue to work if perhaps a tiny bit slower.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

6 participants