Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: change back to github as a source viewer for stdlib #47202

Closed
powerman opened this issue Jul 14, 2021 · 7 comments
Closed

x/pkgsite: change back to github as a source viewer for stdlib #47202

powerman opened this issue Jul 14, 2021 · 7 comments
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.

Comments

@powerman
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/testing

What did you do?

Click on stdlib's function name to view it source code.

What did you expect to see?

https://github.com/golang/go/blob/go1.16.6/src/testing/testing.go#L263

What did you see instead?

https://cs.opensource.google/go/go/+/refs/tags/go1.16.6:src/testing/testing.go;l=263

P.S. I mean it - maybe technically cs.opensource.google/go/go is the repository and github is just a mirror, but using cs.opensource.google instead of github hurts usability, so please revert this change or make it configurable choice.

@gopherbot gopherbot added this to the Unreleased milestone Jul 14, 2021
@powerman powerman changed the title x/pkgsite: x/pkgsite: change back to github as a source viewer for stdlib Jul 14, 2021
@seankhliao
Copy link
Member

can you give specific examples of "hurts usability"?

@seankhliao seankhliao added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jul 14, 2021
@ALTree
Copy link
Member

ALTree commented Jul 14, 2021

change back to github

These links never pointed to github. Before the pkg.go.dev redirect, they went to the files on golang.org/src, like this:

https://web.archive.org/web/20210409132622/https://golang.org/src/archive/tar/writer.go?s=432:876#L9

@twmb
Copy link
Contributor

twmb commented Jul 14, 2021

I too prefer Github, but this was never on GH so there is not a compelling reason to switch to GH.

I think any usability bit is going to be a matter of opinion, though. That said, IMO, a few things that are nice about Github:

  • tabs are wide (they do not look like two spaces)
  • even more colors for syntax highlighting
  • comments are faded more, which has a clearer visual separation from code

@zikaeroh
Copy link
Contributor

zikaeroh commented Jul 14, 2021

FWIW, many (if not all) of those are settings available in top right menu:

image

When the link was changed, I immediately changed the tab size to my preference.

@twmb
Copy link
Contributor

twmb commented Jul 14, 2021

Awesome, I did not know that, thank you!

@go101
Copy link

go101 commented Jul 15, 2021

If you need a rich code reading experience, you can try Golds (https://go101.org/article/tool-golds.html), which provides much richer code reading features than Github. (I'm the author)

@julieqiu
Copy link
Member

This was topic was discussed on #44832. If you have suggestions for the https://cs.opensource.google/go UI, feel free to send feedback to that team by clicking Send Feedback from the dropdown in the top right corner.

Closing this issue.

@golang golang locked and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

9 participants