Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: obsolete comment in zoneinfo.go #47189

Closed
wzzhu opened this issue Jul 14, 2021 · 2 comments
Closed

time: obsolete comment in zoneinfo.go #47189

wzzhu opened this issue Jul 14, 2021 · 2 comments
Labels
FrozenDueToAge

Comments

@wzzhu
Copy link

wzzhu commented Jul 14, 2021

Obsolete comment in src/time/zoneinfo.go

// the start and end times bracketing sec when that zone is in effect,
// the offset in seconds east of UTC (such as -5*60*60), and whether
// the daylight savings is being observed at that time.
func (l *Location) lookup(sec int64) (name string, offset int, isDST bool, start, end int64)

should removed the last one
"and whether the daylight savings is being observed at that time".

Caused by this change:
"remove some unused return parameters" https://cs.opensource.google/go/go/+/8da180f6cac51f6cb8a316b962f797dbaf7ee96f
@mdlayher mdlayher changed the title Obsolete comment in src/time/zoneinfo.go time: obsolete comment in zoneinfo.go Jul 14, 2021
@tklauser
Copy link
Member

The isDST return value was added again in https://golang.org/cl/264077, so incidentally the godoc comment is correct again.

@cherrymui
Copy link
Member

As @tklauser pointed out, this works as intended now. Thanks.

@golang golang locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tklauser @wzzhu @gopherbot @cherrymui