Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bufio: bufio.go has a useless comment #47104

Closed
seifchen opened this issue Jul 9, 2021 · 2 comments
Closed

bufio: bufio.go has a useless comment #47104

seifchen opened this issue Jul 9, 2021 · 2 comments
Labels
FrozenDueToAge

Comments

@seifchen
Copy link
Contributor

seifchen commented Jul 9, 2021

What version of Go are you using (go version)?

$ go version
go version go1.16.4 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/root/go"
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY="***"
GONOSUMDB="***"
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE="***"
GOPROXY="****,direct"
GOROOT="/usr/local/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16.4"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/root/go/src/learn/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1243951107=/tmp/go-build -gno-record-gcc-switches"

What did you do?

When I read the go source， I found in bufio package have one comment in bufio/bufio.go line 29，
// Buffered input
But I did not found any use. Should delete it.
seifchen pushed a commit to seifchen/go that referenced this issue Jul 9, 2021
bufio: delete unuseful comment
8c27b11 
The bufio/bufio.go have one unuseful comment, so delete it.

Fixes golang#47104
@seifchen seifchen mentioned this issue Jul 9, 2021
Closed
seifchen added a commit to seifchen/go that referenced this issue Jul 9, 2021
@seifchen
bufio: delete unuseful comment
57baa99 
The bufio/bufio.go have one unuseful comment, so delete it.

Fixes golang#47104
@seifchen seifchen mentioned this issue Jul 9, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/333470 mentions this issue: bufio: delete unuseful comment

@mknyszek
Copy link
Contributor

mknyszek commented Jul 9, 2021

Thanks for sending a PR. In general, you do not need to open an issue for a small change like this. You can just send the PR.

@mknyszek mknyszek closed this as completed Jul 9, 2021
@mknyszek mknyszek changed the title bufio/bufio.go have unuseful comment bufio: bufio.go has a useless comment Jul 9, 2021
@golang golang locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bufio: delete unuseful comment seifchen/go
bufio: delete unuseful comment seifchen/go
3 participants
@mknyszek @gopherbot @seifchen