Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile, go/types, types2: rename 'imported and not used' error to 'imported but not used' #47089

Open
gazerro opened this issue Jul 7, 2021 · 2 comments · May be fixed by #47237
Open

cmd/compile, go/types, types2: rename 'imported and not used' error to 'imported but not used' #47089

gazerro opened this issue Jul 7, 2021 · 2 comments · May be fixed by #47237
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@gazerro
Copy link
Contributor

gazerro commented Jul 7, 2021

Commit 449b6ab has reworded, in Go 1.14, the "declared and not used" error message as "declared but not used". I propose to do the same for the "imported and not used" error message.

If an imported package is not used, instead of

imported and not used: "fmt"

the error message would be

imported but not used: "fmt"
@gopherbot gopherbot added this to the Proposal milestone Jul 7, 2021
@ianlancetaylor
Copy link
Contributor

This is not an API change and does not need to be a proposal. Taking it out of the proposal process.

@ianlancetaylor ianlancetaylor changed the title proposal: cmd/compile, go/types, types2: rename 'imported and not used' error to 'imported but not used' cmd/compile, go/types, types2: rename 'imported and not used' error to 'imported but not used' Jul 14, 2021
@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. and removed Proposal labels Jul 14, 2021
@ianlancetaylor ianlancetaylor modified the milestones: Proposal, Backlog Jul 14, 2021
@kadern0 kadern0 linked a pull request Jul 16, 2021 that will close this issue
Open
@gopherbot
Copy link

Change https://golang.org/cl/334989 mentions this issue: cmd/compile, go/types, types2: rename 'imported and not used' error to 'imported but not used'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
3 participants
@gazerro @ianlancetaylor @gopherbot