Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: update Dockerfile to Kernel 5.13 #47057

Closed
lhl2617 opened this issue Jul 5, 2021 · 4 comments
Closed

x/sys/unix: update Dockerfile to Kernel 5.13 #47057

lhl2617 opened this issue Jul 5, 2021 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@lhl2617
Copy link

lhl2617 commented Jul 5, 2021

Similar to CL 313391 (Kernel 5.12, Go 1.16.3)
@gopherbot gopherbot added this to the Unreleased milestone Jul 5, 2021
@lhl2617 lhl2617 changed the title x/sys/unix: update Dockerfile to Kernel 5.13, Go 1.16.5 x/sys/unix: update Dockerfile to Kernel 5.13 Jul 5, 2021
@lhl2617
Copy link
Author

lhl2617 commented Jul 5, 2021

There seems to be a lot of definition/enumeration conflicts stemming from <netinet/in.h>.

Running

GOOS=linux GOARCH=amd64 ./mkall.sh

after changing the kernel git clone line in the Dockerfile to 5.13 gives:
https://gist.github.com/lhl2617/4f4407b5549376bc26946b247e8ddd82

@gopherbot
Copy link

Change https://golang.org/cl/332929 mentions this issue: unix: move ICMP{,V6}_FILTER* const definitions

@lhl2617
Copy link
Author

lhl2617 commented Jul 5, 2021

For reference, a non-ideal, sledgehammer approach: https://www.linuxquestions.org/questions/linux-software-2/conflict-between-kernel-and-glibc-headers-when-compiling-ppp-4175594417/

@gopherbot
Copy link

Change https://golang.org/cl/332969 mentions this issue: unix/linux: update Dockerfile to Kernel 5.13

@mknyszek mknyszek added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. NeedsFix The path to resolution is known, but the work has not been done. labels Jul 7, 2021
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 7, 2021
gopherbot pushed a commit to golang/sys that referenced this issue Aug 16, 2021
@tklauser
unix: move ICMP{,V6}_FILTER* const definitions
b1c119f 
The C headers defining these constants pull in <netinet/in.h> which
leads to definition conflicts between kernel and glibc headers when
running mkerrors.sh for Linux kernel 5.13. Avoid these by moving this
const definitions to linux/types.go.

For golang/go#47057

Change-Id: I09a2391dfe4c6bb38b7069e952748070c10824e6
Reviewed-on: https://go-review.googlesource.com/c/sys/+/332929
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@golang golang locked and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mknyszek @gopherbot @lhl2617