Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/template: data race with concurrent ExecuteTemplate calls [1.16 backport] #47042

Closed
gopherbot opened this issue Jul 2, 2021 · 5 comments
Closed

html/template: data race with concurrent ExecuteTemplate calls [1.16 backport] #47042

gopherbot opened this issue Jul 2, 2021 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.8

Comments

@gopherbot
Copy link
Contributor

@josharian requested issue #47040 to be considered for backport to the next 1.16 minor release.

496d7c6 is the fix.

@gopherbot, please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 2, 2021
@gopherbot gopherbot mentioned this issue Jul 2, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.6 milestone Jul 2, 2021
@mknyszek
Copy link
Contributor

mknyszek commented Jul 7, 2021

#47041 is approved, so this one is as well.

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Jul 7, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 7, 2021
@josharian josharian mentioned this issue Jul 12, 2021
Closed
@dmitshur dmitshur modified the milestones: Go1.16.6, Go1.16.7 Jul 12, 2021
@ianlancetaylor
Copy link
Member

See #47041 (comment).

@mknyszek mknyszek added CherryPickCandidate Used during the release process for point releases and removed CherryPickApproved Used during the release process for point releases labels Jul 13, 2021
@toothrot toothrot modified the milestones: Go1.16.7, Go1.16.8 Aug 4, 2021
@toothrot
Copy link
Contributor

toothrot commented Sep 8, 2021

Approved. This is a serious issue with no workaround.

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Sep 8, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Sep 8, 2021
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/348580 mentions this issue: [release-branch.go1.16] text/template: add lock for Template.tmpl to fix data race

@gopherbot
Copy link
Contributor Author

Closed by merging 021fc24 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Sep 9, 2021
@ianlancetaylor
[release-branch.go1.16] text/template: add lock for Template.tmpl to …
021fc24 
…fix data race

This adds a new lock protecting "tmpl".

This is a copy of https://golang.org/cl/257817 by Andreas Fleig,
updated for current tip, and updated to start running the
html/template TestEscapeRace test.

Thanks to @bep for providing the test case.

For #39807
Fixes #47042

Change-Id: Ic8874484290283a49116812eeaffb8608346dc70
Reviewed-on: https://go-review.googlesource.com/c/go/+/316669
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit 496d7c6)
Reviewed-on: https://go-review.googlesource.com/c/go/+/348580
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
@golang golang locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.8
Development

No branches or pull requests
5 participants
@toothrot @mknyszek @dmitshur @ianlancetaylor @gopherbot