Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html/template: data race with concurrent ExecuteTemplate calls [1.15 backport] #47041

Closed
gopherbot opened this issue Jul 2, 2021 · 5 comments
Closed

html/template: data race with concurrent ExecuteTemplate calls [1.15 backport] #47041

gopherbot opened this issue Jul 2, 2021 · 5 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.15.16

Comments

@gopherbot
Copy link

@josharian requested issue #47040 to be considered for backport to the next 1.15 minor release.

496d7c6 is the fix.

@gopherbot, please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 2, 2021
@gopherbot gopherbot mentioned this issue Jul 2, 2021
Closed
@gopherbot gopherbot added this to the Go1.15.14 milestone Jul 2, 2021
@mknyszek
Copy link
Contributor

mknyszek commented Jul 7, 2021

Data race in what is documented to be a concurrent-safe context with no workaround. Approved.

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Jul 7, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 7, 2021
@mknyszek mknyszek mentioned this issue Jul 7, 2021
Closed
@josharian
Copy link
Contributor

Thanks, @mknyszek.

@ianlancetaylor as the original author of the fix, I think the next step is for you to mail a cherry-pick change. Ditto for #47042.

@dmitshur dmitshur modified the milestones: Go1.15.14, Go1.15.15 Jul 12, 2021
@ianlancetaylor
Copy link
Contributor

I have twice had to revert CLs that fix this problem. The current CL has not yet been in any release, so it may just be pending another revert. I think it would be very premature to backport the CL to the 1.15 and 1.16 branches before the 1.17 release is out.

@mknyszek
Copy link
Contributor

@ianlancetaylor Sounds good, I'll un-approve then.

@mknyszek mknyszek added CherryPickCandidate Used during the release process for point releases and removed CherryPickApproved Used during the release process for point releases labels Jul 13, 2021
@toothrot toothrot modified the milestones: Go1.15.15, Go1.15.16 Aug 4, 2021
@dmitshur
Copy link
Contributor

Go 1.17 has been released, and so Go 1.15 is no longer supported per the release policy. Closing.

@golang golang locked and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.15.16
Development

No branches or pull requests
6 participants
@toothrot @josharian @mknyszek @dmitshur @ianlancetaylor @gopherbot