Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: umbrella issue for release-blocking fuzzing work #47037

Closed
10 of 22 tasks
katiehockman opened this issue Jul 2, 2021 · 9 comments
Closed
10 of 22 tasks

all: umbrella issue for release-blocking fuzzing work #47037

katiehockman opened this issue Jul 2, 2021 · 9 comments
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. umbrella
Milestone

Comments

@katiehockman
Copy link
Contributor

katiehockman commented Jul 2, 2021

This is the tracking issue for fuzzing-related work which must be done before fuzzing can be part of a standard release of the Go toolchain.

The current plan is to merge the fuzzing code into master once the tree opens in the fall of this year (2021).
This would make fuzzing available for Go 1.18.

The following is a list of release-blocking features (in no particular order):

The following is a list of nice-to-have features (in a rough order):

There are other issues with the 'fuzz' label which will also be release blockers once fuzzing is merged. Once the tree is open, the release blocker label will be used at that time.

Which items are in the "release-blocker" list and which are in the "nice-to-have" list may change over time, depending on user feedback, and new items may be added at any time as well.

/cc @golang/fuzzing

@katiehockman katiehockman added NeedsFix The path to resolution is known, but the work has not been done. fuzz Issues related to native fuzzing support labels Jul 2, 2021
@katiehockman katiehockman added this to the Go1.18 milestone Jul 2, 2021
@katiehockman katiehockman changed the title [dev.fuzz] all: tracking issue for release-blocking fuzzing work [dev.fuzz] all: umbrella issue for release-blocking fuzzing work Sep 9, 2021
@gopherbot
Copy link

Change https://golang.org/cl/351118 mentions this issue: cmd/go: disable gofuzzbeta build tag by default

@rsc rsc changed the title [dev.fuzz] all: umbrella issue for release-blocking fuzzing work all: umbrella issue for release-blocking fuzzing work Sep 21, 2021
gopherbot pushed a commit that referenced this issue Sep 21, 2021
It was enabled by default on the dev.fuzz branch so that users could
check in fuzz targets without breaking their builds.

Now that dev.fuzz is merged to master, users should switch to a go1.18
release constraint instead.

For #47037

Change-Id: I0475368eb4570fe0c7027a3ae8f6950449c1a9ca
Reviewed-on: https://go-review.googlesource.com/c/go/+/351118
Trust: Jay Conrod <jayconrod@google.com>
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
gopherbot pushed a commit to golang/website that referenced this issue Oct 4, 2021
CL 351569 updated this blog post to use gotip without arguments,
since the dev.fuzz branch has been merged to the main branch and
is slated to be included in Go 1.18.

Update the build constraint in the shown example accordingly,
since the gofuzzbeta constraint is no longer set as of CL 351118.
Suggest the use of a go1.18 build constraint instead.

While here, also update to the newer go install @latest
syntax for downloading the gotip command, for reasons
similar to what's described in CL 346091.

For golang/go#47037.
Updates golang/go#48080.

Change-Id: Icbf3d3ad5ef5532063ca3e093eed330f7ea0c0d9
Reviewed-on: https://go-review.googlesource.com/c/website/+/353430
Website-Publish: DO NOT USE <dmitshur@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Katie Hockman <katie@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/353430 mentions this issue: go.dev/_content/blog: update build constraints in fuzz-beta post

@katiehockman katiehockman modified the milestones: Go1.18, Unreleased Nov 10, 2021
@AlekSi
Copy link
Contributor

AlekSi commented Jan 6, 2022

Fuzzing works with -race and -msan. It doesn't have to add a lot of additional value, but the go tool shouldn't break.

Currently, -race reports a data race in SnapshotCoverage(). Is it a known problem? Should there be a separate ticket for that?

@AlekSi
Copy link
Contributor

AlekSi commented Jan 6, 2022

(Also, this ticket is a bit confusing. For example, the title says "release-blocking", but the milestone is "Unreleased")

@katiehockman katiehockman modified the milestones: Unreleased, Go1.18 Jan 6, 2022
@katiehockman
Copy link
Contributor Author

I went ahead and updated the milestone. (This is just an umbrella issue used for tracking and external visibility, so any issues/requests should be filed as separate tickets)

@AlekSi could you file a new issue for the -race issue. We need to look into that again, and AFAIK there isn't an open ticket for it. Thanks.

@katiehockman
Copy link
Contributor Author

@rolandshoemaker tried to reproduce that race issue locally, and wasn't able to. I'm going to go ahead and mark that done in the umbrella issue, and just close this. This issue was really just for tracking anyway.

But @AlekSi please still file your issue if you can reproduce it at tip.

@thepudds
Copy link
Contributor

thepudds commented Jan 6, 2022

FWIW, I’ve been using -race and -fuzz together a fair amount for the past several weeks without an issue, so maybe it is related to the exact code under test.

@AlekSi
Copy link
Contributor

AlekSi commented Jan 7, 2022

#50488

@katiehockman
Copy link
Contributor Author

Thanks, @AlekSi for filing that issue!

passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
CL 351569 updated this blog post to use gotip without arguments,
since the dev.fuzz branch has been merged to the main branch and
is slated to be included in Go 1.18.

Update the build constraint in the shown example accordingly,
since the gofuzzbeta constraint is no longer set as of CL 351118.
Suggest the use of a go1.18 build constraint instead.

While here, also update to the newer go install @latest
syntax for downloading the gotip command, for reasons
similar to what's described in CL 346091.

For golang/go#47037.
Updates golang/go#48080.

Change-Id: Icbf3d3ad5ef5532063ca3e093eed330f7ea0c0d9
Reviewed-on: https://go-review.googlesource.com/c/website/+/353430
Website-Publish: DO NOT USE <dmitshur@google.com>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Katie Hockman <katie@golang.org>
@golang golang locked and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge fuzz Issues related to native fuzzing support NeedsFix The path to resolution is known, but the work has not been done. umbrella
Projects
Status: No status
Development

No branches or pull requests

5 participants