Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/crypto: include shamir secret sharing algorithm #47033

Closed
bradbl opened this issue Jul 2, 2021 · 6 comments
Closed

proposal: x/crypto: include shamir secret sharing algorithm #47033

bradbl opened this issue Jul 2, 2021 · 6 comments
Labels
FrozenDueToAge Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone

Comments

@bradbl
Copy link

bradbl commented Jul 2, 2021

I propose the inclusion of the Shamir's Secret Sharing algorithm into the x/crypto tree under a new package titled shamir.

This is a common solution to the problem of splitting a secret securely for distribution to multiple parties.

If this meets the criteria for inclusion, I would be happy to submit a patch. Thanks!

@gopherbot gopherbot added this to the Unreleased milestone Jul 2, 2021
@ianlancetaylor ianlancetaylor changed the title x/crypto: proposal to include shamir secret sharing algorithm proposal: x/crypto: include shamir secret sharing algorithm Jul 2, 2021
@ianlancetaylor ianlancetaylor modified the milestones: Unreleased, Proposal Jul 2, 2021
@ianlancetaylor ianlancetaylor added the Proposal-Crypto Proposal related to crypto packages or other security issues label Jul 2, 2021
@ianlancetaylor ianlancetaylor added this to Incoming in Proposals (old) Jul 2, 2021
@rsc
Copy link
Contributor

rsc commented Oct 20, 2021

Is there any kind of standard message format or encoding for the secret parts? Any RFC or other document?

I understand the algorithm; I am trying to understand whether this would need to or be able to interoperate with any other system. If there are no systems to interoperate with, that raises a question of why, and whether we need to add it to Go.

/cc @FiloSottile

@bradbl
Copy link
Author

bradbl commented Oct 20, 2021

That's a good question. I'm not aware of an RFC for this algorithm or any other authoritative standards document. It's primarily described by academic literature. Perhaps this isn't a good fit for x/crypto in that case.

@rsc
Copy link
Contributor

rsc commented Oct 27, 2021

Usually the reason to put something in the standard library (or x/crypto) is to interoperate with other code that would be using the same exact algorithms/protocols/etc. This doesn't seem to fit in that bucket. It would probably be best to start with a package outside the standard library. See https://golang.org/doc/faq#x_in_std for more.

@bradbl
Copy link
Author

bradbl commented Oct 27, 2021

Ok, thanks @rsc for the clarification. Closing.

@bradbl bradbl closed this as completed Oct 27, 2021
@rsc
Copy link
Contributor

rsc commented Oct 27, 2021

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc rsc moved this from Incoming to Active in Proposals (old) Oct 27, 2021
@rsc rsc moved this from Active to Declined in Proposals (old) Nov 3, 2021
@rsc
Copy link
Contributor

rsc commented Nov 3, 2021

This proposal has been declined as retracted.
— rsc for the proposal review group

@golang golang locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Proposal Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
No open projects
Development

No branches or pull requests

4 participants