Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/cache: SIGSEGV in (*snapshot).GetCriticalError #47030

Closed
bcmills opened this issue Jul 2, 2021 · 1 comment
Closed

x/tools/gopls/internal/lsp/cache: SIGSEGV in (*snapshot).GetCriticalError #47030

bcmills opened this issue Jul 2, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.1

Comments

@bcmills
Copy link
Contributor

bcmills commented Jul 2, 2021

2021-07-02T16:14:50-7edcfe5/linux-386-stretch
2021-06-30T16:45:04-f0847e0/linux-ppc64le-power9osu
2021-06-29T19:12:30-72e4d1b/darwin-arm64-11_0-toothrot
2021-06-29T19:12:30-72e4d1b/linux-386-longtest
2021-06-29T14:11:33-100b229/linux-amd64-wsl
2021-06-29T14:11:33-100b229/linux-arm-aws

The stacks are similar across the board:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x85eb484]

goroutine 36157 [running]:
golang.org/x/tools/internal/lsp/cache.(*snapshot).GetCriticalError(0x1f1e95f0, {0x8a334a0, 0x1f429158})
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/cache/snapshot.go:1279 +0x84
golang.org/x/tools/internal/lsp/cache.(*snapshot).ModTidy(0x1f1e95f0, {0x8a334a0, 0x1f429158}, 0x1f9db720)
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/cache/mod_tidy.go:75 +0x197
golang.org/x/tools/internal/lsp/mod.DiagnosticsForMod({0x8a334a0, 0x1f429158}, {0x8a513f4, 0x1f1e95f0}, {0xe46ca180, 0x1f8d2770})
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/mod/diagnostics.go:103 +0xc86
golang.org/x/tools/internal/lsp/mod.Diagnostics({0x8a334a0, 0x1f428c90}, {0x8a513f4, 0x1f1e95f0})
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/mod/diagnostics.go:31 +0x2e3
golang.org/x/tools/internal/lsp.(*Server).diagnose(0x1f712bd0, {0x8a33800, 0x1f422c50}, {0x8a513f4, 0x1f1e95f0}, 0x0)
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/diagnostics.go:184 +0x2dd
golang.org/x/tools/internal/lsp.(*Server).diagnoseDetached(0x1f712bd0, {0x8a513f4, 0x1f1e95f0})
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/diagnostics.go:90 +0x99
golang.org/x/tools/internal/lsp.(*Server).didChangeConfiguration.func1({0x8a4626c, 0x9bb6cc0}, {0x8a334a0, 0x1fada6f0}, 0x1f712bd0)
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/workspace.go:85 +0x6c
created by golang.org/x/tools/internal/lsp.(*Server).didChangeConfiguration
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/workspace.go:82 +0x147
FAIL	golang.org/x/tools/gopls/internal/regtest/misc	61.919s

CC @stamblerre @findleyr
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jul 2, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jul 2, 2021
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 2, 2021
@bcmills bcmills changed the title x/tools/gopls/internal/lsp: SIGSEGV in (*snapshot).GetCriticalError x/tools/gopls/internal/lsp: SIGSEGV in cache.(*snapshot).GetCriticalError Jul 2, 2021
@bcmills bcmills changed the title x/tools/gopls/internal/lsp: SIGSEGV in cache.(*snapshot).GetCriticalError x/tools/gopls/internal/lsp/cache: SIGSEGV in (*snapshot).GetCriticalError Jul 2, 2021
@findleyr findleyr self-assigned this Jul 2, 2021
@gopherbot
Copy link

Change https://golang.org/cl/332589 mentions this issue: internal/lsp/cache: don't report a context error if load succeeded

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.7.1 Jul 7, 2021
@findleyr findleyr added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 7, 2021
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.1
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr