Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: fix docs for -test.timeout #4702

Closed
gopherbot opened this issue Jan 24, 2013 · 2 comments
Closed

cmd/go: fix docs for -test.timeout #4702

gopherbot opened this issue Jan 24, 2013 · 2 comments
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone

Comments

@gopherbot
Copy link

by myannikos:

What steps will reproduce the problem?

Run any test that takes longer than 1 minute with

  go test -test.bench . -test.timeout 0

What is the expected output?

  The test should run forever OR with the default 10 minutes limit (which is not well documented by the way)

What do you see instead?

  The test is aborted after 1 minute

Which compiler are you using (5g, 6g, 8g, gccgo)?

  6g

Which operating system are you using?

  Debian squeeze x86-64

Which version are you using?  (run 'go version')
 
  1.0.3

Please provide any additional information below.

This is either a documentation issue:

[go test usage info]
  -test.timeout=0: if positive, sets an aggregate time limit for all tests

Or an implementation issue:

pkg/code.google.com/p/go/src/cmd/go/test.go:

    // If a test timeout was given and is parseable, set our kill timeout
    // to that timeout plus one minute.  This is a backup alarm in case
    // the test wedges with a goroutine spinning and its background
    // timer does not get a chance to fire.
    if dt, err := time.ParseDuration(testTimeout); err == nil {
        testKillTimeout = dt + 1*time.Minute
    }

(this should probably be "parseable and positive")
@minux
Copy link
Member

minux commented Jan 24, 2013

Comment 1:

Labels changed: added priority-later, suggested, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Jan 31, 2013

Comment 2:

This issue was closed by revision 8b6534b.

Status changed to Fixed.

@gopherbot gopherbot added fixed Suggested Issues that may be good for new contributors looking for work to do. labels Jan 31, 2013
@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Development

No branches or pull requests

3 participants