Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go mod vendor: open C:\Users\LICENSE: Access is denied. [1.16 backport] #47015

Closed
gopherbot opened this issue Jul 1, 2021 · 2 comments
Closed

cmd/go: go mod vendor: open C:\Users\LICENSE: Access is denied. [1.16 backport] #47015

gopherbot opened this issue Jul 1, 2021 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go OS-Windows
Milestone
Go1.16.7

Comments

@gopherbot
Copy link

@bcmills requested issue #46867 to be considered for backport to the next 1.16 minor release.

@gopherbot, please backport. This bug has a trivial fix, and the failure mode is fairly confusing with no obvious workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jul 1, 2021
@gopherbot gopherbot mentioned this issue Jul 1, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.6 milestone Jul 1, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/332329 mentions this issue: [release-branch.go1.16] cmd/go: use path.Dir instead of filepath.Dir for package paths in 'go mod vendor'

@bcmills bcmills self-assigned this Jul 1, 2021
@dmitshur dmitshur added the GoCommand cmd/go label Jul 1, 2021
@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Jul 8, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jul 8, 2021
@dmitshur dmitshur modified the milestones: Go1.16.6, Go1.16.7 Jul 12, 2021
@gopherbot
Copy link
Author

Closed by merging 37c117f to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Aug 3, 2021
@mattn @cagedmantis
[release-branch.go1.16] cmd/go: use path.Dir instead of filepath.Dir …
37c117f 
…for package paths in 'go mod vendor'

copyMetadata walk-up to parent directory until the pkg become modPath.
But pkg should be slash-separated paths. It have to use path.Dir instead of
filepath.Dir.

Updates #46867
Fixes #47015

Change-Id: I44cf1429fe52379a7415b94cc30ae3275cc430e8
Reviewed-on: https://go-review.googlesource.com/c/go/+/330149
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Trust: Alexander Rakoczy <alex@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
(cherry picked from commit 835d86a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/332329
Reviewed-by: Jay Conrod <jayconrod@google.com>
@rsc rsc unassigned bcmills Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go OS-Windows
Projects
None yet
Milestone
Go1.16.7
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot