Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: typo in comment #46982

Closed
komisan19 opened this issue Jun 30, 2021 · 2 comments
Closed

cmd/dist: typo in comment #46982

komisan19 opened this issue Jun 30, 2021 · 2 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.

Comments

@komisan19
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.16 linux/amd64

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/home/vagrant/go/bin"
GOCACHE="/home/vagrant/.cache/go-build"
GOENV="/home/vagrant/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/vagrant/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/vagrant/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.16"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2823638017=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Read the source code at https://github.com/golang/go/blob/master/src/cmd/dist/test.go#L784

I think syscall.SysProcAttr, not syscall.SysProcAttri.
Sorry if I'm wrong.

What did you expect to see?

// because syscall.SysProcAttri struct used in misc/cgo/testsanitizers is only built on linux.

What did you see instead?

// because syscall.SysProcAttr struct used in misc/cgo/testsanitizers is only built on linux.
@komisan19 komisan19 mentioned this issue Jun 30, 2021
Closed
@gopherbot
Copy link

Change https://golang.org/cl/331869 mentions this issue: style: fix incorrect document in misspell

@seankhliao seankhliao changed the title style: fix incorrect document in misspell cmd/dist: typo in comment Jun 30, 2021
@seankhliao
Copy link
Member

Hey there, It's not necessary to open an issue for a documentation fix if you are going to send a patch anyhow. It's OK to just send the patch without an issue. Thanks.

@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 30, 2021
@golang golang locked and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/dist: correct comment: SysProcAttri -> SysProcAttr komisan19/go
3 participants
@gopherbot @seankhliao @komisan19