Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestCVE202133195 fails if /etc/resolv.conf specifies ndots larger than 3 [1.16 backport] #46981

Closed
gopherbot opened this issue Jun 30, 2021 · 5 comments
Closed

net: TestCVE202133195 fails if /etc/resolv.conf specifies ndots larger than 3 [1.16 backport] #46981

gopherbot opened this issue Jun 30, 2021 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.16.6

Comments

@gopherbot
Copy link

@shawn-xdji requested issue #46955 to be considered for backport to the next 1.16 minor release.

@gopherbot please backport to 1.16
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 30, 2021
@gopherbot gopherbot mentioned this issue Jun 30, 2021
Closed
@gopherbot gopherbot added this to the Go1.16.6 milestone Jun 30, 2021
@dmitshur
Copy link
Contributor

@shawn-xdji Please add a brief rationale for why you believe the fix for that issue should be backported. Thanks.

We'll need to make the backport issue for 1.15 by hand, because gopherbot currently doesn't support follow up requests. Made #46994.

@neild
Copy link
Contributor

neild commented Jun 30, 2021

This only affects running net package tests with an unusual /etc/resolv.conf configuration. It has no impact outside of the net package's own tests. I don't think it meets the criteria for a backport.

@shawndx
Copy link
Contributor

shawndx commented Jul 4, 2021

@dmitshur @neild We deployed both go1.15 and 1.16 for large-scale network applications where they all share the almost same /etc/resolv.conf, the failure breaks its periodical sync-up to upstream releases and evaluation flow which runs all unit-testcases, hope to have the fix in go repo, instead of bypassing it in the evaluation.

Thanks @dmitshur for filing the 1.15 issue.

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jul 4, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/333332 mentions this issue: [release-branch.go1.16] net: fix failure of TestCVE202133195

@neild
Copy link
Contributor

neild commented Jul 8, 2021

CL 333330 incorporates this fix on release-branch.go1.16.

@neild neild closed this as completed Jul 8, 2021
@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jul 8, 2021
@golang golang locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.16.6
Development

No branches or pull requests
4 participants
@neild @dmitshur @gopherbot @shawndx